Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWAs create invalid .desktop files #347

Open
kees-closed opened this issue Dec 23, 2024 · 0 comments
Open

PWAs create invalid .desktop files #347

kees-closed opened this issue Dec 23, 2024 · 0 comments

Comments

@kees-closed
Copy link

When creating a PWA, it creates an invalid desktop file:

#!/usr/bin/env xdg-open
[Desktop Entry]
Version=1.0
Terminal=false
Type=Application
Name=Microsoft Teams
Exec=flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'
Icon=chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default
NoDisplay=true
StartupWMClass=crx_cifhbcnohmdccbgoicgdjpfamggdegmo
X-Flatpak-Part-Of=com.google.Chrome
TryExec=/var/lib/flatpak/exports/bin/com.google.Chrome

When running this validation tool, it complains about the following:

$ desktop-file-validate com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop 
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote
com.google.Chrome.flextop.chrome-cifhbcnohmdccbgoicgdjpfamggdegmo-Default.desktop: error: value "flatpak 'run' '--command=/app/bin/chrome' 'com.google.Chrome' '--profile-directory=Default' '--app-id=cifhbcnohmdccbgoicgdjpfamggdegmo'" for key "Exec" in group "Desktop Entry" contains a reserved character ''' outside of a quote

This is fixed when changing the Exec to:

Exec=flatpak run --command=/app/bin/chrome com.google.Chrome --profile-directory=Default --app-id=cifhbcnohmdccbgoicgdjpfamggdegmo

Both Exec's work, but only the latter Exec is valid according to the desktop-file-validate tool.

I'm using version 131.0.6778.204-1 of the Chrome Flatpak on Fedora Silverblue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant