Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky -alsa option prevents jack as default #95

Closed
agraef opened this issue Dec 1, 2024 · 3 comments
Closed

Sticky -alsa option prevents jack as default #95

agraef opened this issue Dec 1, 2024 · 3 comments

Comments

@agraef
Copy link
Contributor

agraef commented Dec 1, 2024

See rev. 6088c35. The -alsa -alsaadd pulse options in the launch script prevent setting the audio api to jack in the preferences to take effect on startup. The solution is simple: Move those options to the flags setting in the default.settings file, so that the user can remove them if wanted.

@ssssam
Copy link
Collaborator

ssssam commented Dec 4, 2024

Hello! Seems like a good idea -- i havent been working on this recently but would be happy to merge a PR

@agraef
Copy link
Contributor Author

agraef commented Dec 4, 2024

Hi Sam! I think that #96 should do the trick. Tested on a PC running Arch, seems to work as intended there.

@ssssam ssssam closed this as completed in be2028c Dec 5, 2024
ssssam added a commit that referenced this issue Dec 5, 2024
Move sticky -alsa option to default settings. Fixes #95.
@ssssam
Copy link
Collaborator

ssssam commented Dec 5, 2024

I think I did this because I was having problems with JACK and wanted something that "just works". But it's better to allow folk to override, indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants