Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins do not seem to properly restore state #3

Closed
Gert-dev opened this issue Aug 31, 2021 · 3 comments · Fixed by #7
Closed

Plugins do not seem to properly restore state #3

Gert-dev opened this issue Aug 31, 2021 · 3 comments · Fixed by #7

Comments

@Gert-dev
Copy link

It appears that the settings of some plugins are not retained after a restart.

Steps to reproduce:

  1. Open the plugins panel.
  2. Enable the "WebKit Setting" plugin.
  3. Open its preferences.
  4. Disable "Auto Load Images".
  5. Close Liferea.
  6. Start Liferea again.
  7. Going back to the preferences shows the setting appears to have reset.

This doesn't happen with the Liferea from the native Arch repositories. I don't exactly understand why this happens, since the settings do appear to be persisted properly to ~/.var/app/net.sourceforge.liferea/config/liferea/plugins/webkitsetting/webkitsetting.ini.

@bbhtt
Copy link
Contributor

bbhtt commented Jan 27, 2022

How did you install that plugin?

Downloading the external plugins apparently requires git which is not present inside the sandbox, expectedly; so it throws an error:

Screenshot

@Gert-dev
Copy link
Author

Ah, I must have worked around that by accident by copying my liferea configuration into the .var/app folder from the native Arch Linux build, as I was trying to migrate to the Flatpak. I copied over the plugins along that way, it seems.

@bbhtt
Copy link
Contributor

bbhtt commented Jan 28, 2022

Workaround:

Keep the plugin config in ~/.config/liferea/plugins, run Liferea with $ flatpak run --filesystem=xdg-config/liferea/plugins net.sourceforge.liferea this should allow reading and writing the plugin config and it should persist. If you only need read-only access to the config $ flatpak run --filesystem=xdg-config/liferea/plugins:ro net.sourceforge.liferea.

If this works you can add it as an override: $ flatpak override --filesystem=xdg-config/liferea/plugins net.sourceforge.liferea

Investigation:

I tried including git to the manifest to allow installing the external plugins from inside the sandbox, but Liferea clones the plugin repo to /tmp and tries to copy them to /home/user/.local/share/plugins,(instead of /home/user/.var/app/net.sourceforge.liferea/data/liferea/plugins) to which it doesn't have access so it fails and no plugin gets installed.

Edit. Ok, found the issue.

Filed:

  1. Get Focus Plugin: Get Focus plugin fails to save/read settings under Flatpak lwindolf/liferea#1077
  2. Pane Position Plugin: Pane position plugin fails to save/read settings under Flatpak lwindolf/liferea#1080
  3. Plugin Installer: Plugin installer copies to wrong path under Flatpak lwindolf/liferea#1079
  4. Webkit Settings Plugin: Use XDG_* variables to save config/state mozbugbox/liferea-plugin-studio#14
  5. Feedalert Plugin: Use XDG_* variable to save config paulpritchard68/liferea-plugins#2

This should cover all the included and listed plugins in Liferea

Once the plugin insatller is fixed I think we can possibly add git to the manifest so Liferea can install external plugins from inside the sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants