-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen sleep isn't suppressed with the suspend screensaver option turned on #58
Comments
Does this happen on the |
Just add |
I've only tested using Flatpak. --talk-name=org.freedesktop.ScreenSaver when running doesn't solve the problem. |
Can you post the output of:
(Up to the point where it should be inhibiting) |
Weird, there is no output at all on the terminal. Should I look somewhere alse? |
--verbose will force stdout |
|
$ flatpak run --talk-name=org.freedesktop.ScreenSaver --log-session-bus --verbose org.libretro.RetroArch I started Retroarch, started some content and did nothing until the screen faded. This doesn't seem very helpful. Strange, I remember that when I first tried Retroarch flatpak a couple of weeks ago it printed more when started on the command line. I updated recently. Is there a way to downgrade to a previous flatpak release? |
Would like to fix this issue before we come to that... Does this happen on RetroArch 1.7.3 without Flatpak for you? There's been some updates in the gfx drivers. |
Well, I'm relying on Flatpak to get RetroArch effortlessly. :) But, I can recognize when it's time to help nice people trying to help you. I'll try to make a local build this weekend and report my findings. By the way, I've experienced a framerate reduction such that I can't really make any core run smoothly. This was running smoothly (after setting the framerate) in 1.7.2. I will test the local build and file an issue if it appears to be Flatpak related. |
Wouldn't be one of these, right? https://github.com/flathub/org.libretro.RetroArch/pull/54/files |
|
(Actually I can confirm retroarch breaks |
Ok, I managed to compile 1.7.3 (and master, and 1.7.2) and the problem isn't related to Flatpak. The culprit appears to be Wayland support. Also the framerate problem seems to be Wayland related. If I compile without Wayland support both problems disappear. I will create bug reports directly to RetroArch. |
Well, this issue is more subtle than it appears. We have actually two different bugs that confused me. The first is that (apparently) Suspend screensaver doesn't work under Wayland. This isn't Flatpak related and I've reported it here: libretro/RetroArch#6830 However, when I've tried to run the Flatpak RetroArch under X the Suspend screensaver did not work, while it worked in a version I compiled and run under X. Luckily I managed to get logs working (the -v should be last!) and look what I've found!
The problem, at least under X, seems to be Flatpak related after all. There is a binary missing. Reopening the bug. |
The plot thickens! I discovered something interesting peeking at the code: xdg-screensaver is a fallback, the primary way to inhibit the screensaver is Dbus. The default RetroArch build options have Dbus support disabled, and so did my own builds. If I enable Dbus support and recompile I get (under X):
It works perfectly. I'm not sure, but it appears that the Flatpak builds use the default configuration, then Dbus is disabled. Maybe it is better for the Flatpak build to enable Dbus instead of trying to add xdg-screensaver. |
Bug libretro/RetroArch#6830 has been closed. Wayland support for suppressing the screensaver is Dbus only. So, I suppose the Flatpak build should support Dbus and handle both X11 and Wayland. |
I'm pretty sure this is libretro/RetroArch#15856, which isn't in released yet. What happens is that on wayland there are 2 ways to inhibit the screensaver:
You can run retroarch with
I can prep a PR to backport libretro/RetroArch@e7a10b2 until there's another release. |
BTW, if the compositor doesn't support the Wayland protocol like mutter before GNOME 45, you'll see this in the verbose messages:
|
Thanks for the investigation. Had pushed a config to disable this until it's fixed, which we can revert once it's up. As for the PR that's not released yet, RetroArch 1.17 is coming out within the next couple weeks, so hopefully the release with the DBUS fix solves this 👍 #274 |
Just to add one more comment. So, while it would be pretty easy to bundle the scripts, it would require also bundling a few perl libraries to actually work correctly. IMO, post-1.17 it would be best to just assume that the environment supports the To sum up, the post-1.17 suppress screensaver support would be:
|
I don't have a screen saver, but my screen turns off after some time of inactivity. When running Retroarch, joypad input doesn't count as activity and the suspend screensaver option does not keep the screen from sleeping. After some research, I believe this option (suspend screensaver) should suppress screen sleep in Linux and that it is Dbus related:
libretro/RetroArch#2026
libretro/RetroArch@05df632
Maybe the Retroarch flatpak doesn't support the correct Dbus interface?
The text was updated successfully, but these errors were encountered: