Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release (v0.6.9) doesn't match with documentation regarding self-signed certificates #285

Open
mainakae opened this issue May 10, 2015 · 3 comments · Fixed by #286

Comments

@mainakae
Copy link

First and foremost: thanks for this amazing library!, it saved me tones of work!.

Now a quick (and hopefully easy to fix ;) ) issue: I've been banging my head for some two days now, trying to figure out why cradle won't make any difference wether I configure the self-signed certificate or not, using the "ca" param stated in the documentation.

Tried to debug from the sources in node_modules and found that there was no code using the parameter, although there certainly was in the github repo.

Long story short: the latest release available, doesen't contain that code, thus doesn't match the documentation as seen in github, leading to the error at hand.

Fixed easy and dirty removing the dependency and reinstalling with "npm install --save git+https://github.com/flatiron/cradle.git#632a9fededb774ba5ecb94d3a268280f1bb62a88" (latest commit at the moment). All working now! (though it would be better to avoid that hack ;) )

Thanks again and happy coding!

@panuhorsmalahti
Copy link
Contributor

Yeah, we haven't had a release in a while. 0.7.0 should be released soon.

@mainakae
Copy link
Author

Now, THAT was FAST!

Thanks!!

@KingScooty
Copy link

The package json is referring to v0.7.1, but the latest github tag is v.0.6.9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants