Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up job folders after usage is complete #187

Open
WardBrian opened this issue Jul 31, 2024 · 2 comments
Open

Clean up job folders after usage is complete #187

WardBrian opened this issue Jul 31, 2024 · 2 comments

Comments

@WardBrian
Copy link
Collaborator

We want to keep the compiled targets for caching, but the actual job folder is still a one-and-done

@WardBrian WardBrian added this to the post-1.0 milestone Jul 31, 2024
@magland
Copy link
Collaborator

magland commented Jul 31, 2024

We want to keep the compiled targets for caching, but the actual job folder is still a one-and-done

Perhaps it should be this way. But right now the main.js and wasm ends up on the job folder. But even in that case, it makes sense to delete them after a time.

@WardBrian
Copy link
Collaborator Author

Yes, right now we assume the url will be in the job folder in the frontend:

const downloadMainJsUrl = `${stanWasmServerUrl}/job/${job_id}/download/main.js`;

It would be relatively easy to have the backend instead reply with a link, which we could point straight into the cache, rendering the job folder irrelevant after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants