-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate script editors, add analysis.R #157
Conversation
Very Cool! Before I start reading the code, I wanted to test to see if everything is working. One thing I noticed (I think it was introduced in this PR). When I run the python data generation script it always needs to reload pyodide. Is the worker getting terminated? data.R does not have this problem. analysis.py and analysis.R also do not have this problem. |
@magland I observe the behavior you are describing on the current Otherwise, another point in favor of #142, possibly |
@magland I believe it is fixed. Basically, the onData part of the callback was changing after every run, since it depended on the data, so it re-loaded the usePyodide hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments. We should merge this soon because there are so many changes and renames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine. There's a couple minor things that might be slightly cleaner, but I'd also be happy to just merge as is.
76574e7
to
afeec3c
Compare
I decided to open this as a replacement to PR #155 rather than just pushing to that branch because I did a bunch of code moves.
This PR:
ScriptEditor
and its big brother,PlottingScriptEditor
. These are the basis of the data and analysis tabs.app/Scripting
) and move any large R/Python code chunks out of strings and into their own dedicate files.Only this final bullet point changes any of the functionality, the rest is just tech debt cleanup.
Closes #106
Closes #58