Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent colours support #498

Open
g7 opened this issue Sep 27, 2024 · 1 comment
Open

Accent colours support #498

g7 opened this issue Sep 27, 2024 · 1 comment

Comments

@g7
Copy link

g7 commented Sep 27, 2024

Hi,

would you be open to accept eventual contributions regarding accent colour support? I understand it might be a bit tricky, and perhaps it would be better to defer to the DE-specific desktop environments' portals.

But I see that there are some GNOME specific settings being handled by xdg-desktop-portal-gtk already. Would adding support for accent-color support in xdg-desktop-portal-gtk acceptable for you? Context is adding support for shells like phosh.

I assume it might be a bit tricky as the various desktops might not use the Adwaita colour palette, so we can't really hardcode the colours (and neither pull in libadwaita and retrieve those from there).

Thanks!

@yuki0iq
Copy link

yuki0iq commented Oct 16, 2024

Settings portal exposes RGB values as accent-color, and not strings nor some fixed keys. It would be nice to be able to specify accent color as a plain RGB triple which is independent of libadwaita palette.

g7 pushed a commit to droidian/phosh that referenced this issue Oct 24, 2024
The GTK portal doesn't support accent colors yet:

    flatpak/xdg-desktop-portal-gtk#498

and we want to be able to set wallpapers.

Signed-off-by: Guido Günther <[email protected]>
agx added a commit to agx/phosh that referenced this issue Oct 25, 2024
The GTK portal doesn't support accent colors yet:

    flatpak/xdg-desktop-portal-gtk#498

and we want to be able to set wallpapers.

Signed-off-by: Guido Günther <[email protected]>
Part-of: <https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1552>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants