Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifications: Support inline-reply? #485

Closed
fmuellner opened this issue May 12, 2020 · 6 comments · Fixed by #1298
Closed

notifications: Support inline-reply? #485

fmuellner opened this issue May 12, 2020 · 6 comments · Fixed by #1298
Labels
needs discussion Needs discussion on how to implement or fix the corresponding task new api This requires adding API to an existing portal portal: notifications Notifications portal

Comments

@fmuellner
Copy link

This is currently under discussion for the org.freedesktop.Notifications spec:

https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/24

I'm sympathetic to the idea, but want to discuss this in the portal context first to not create an incentive for apps to use the underlying freedesktop API over the portal.

In my opinion the worst bit in the proposal is piggybacking the reply on the action, which luckily wouldn't be a problem with the portal API where actions have proper parameters.

So does this look like a worthwhile addition?
@TingPing
Copy link
Member

Worth mentioning that xdg-desktop-portal-gtk uses the org.gtk.Notifications interface so it must support this also.

@fmuellner
Copy link
Author

But org.gtk.Notifications is a private protocol that is undocumented as far as I can tell, and the proposal doesn't require any changes to the D-Bus API. We only need to agree on a new possible a{sv} entry, and the easiest option is to just use whatever the portal ends up with.

@matthiasclasen
Copy link
Contributor

I think allowing responses is fine.

I admit that the talk of serialization and deserialization in that proposal makes me anticipate the interoperability and robustness issues we're going to see...

@ZanderBrown
Copy link
Contributor

Ideally like org.freedesktop.portal.Notification and org.freedesktop.Application we'd have parameter support in org.freedesktop.Notifications, but we don't

@kbroulik
Copy link

kbroulik commented Aug 1, 2020

Any progress here?

@Mikenux
Copy link

Mikenux commented Aug 29, 2023

There is now a proposal to talk about it: #983

@GeorgesStavracas GeorgesStavracas added new api This requires adding API to an existing portal needs discussion Needs discussion on how to implement or fix the corresponding task portal: notifications Notifications portal labels Oct 3, 2023
@jsparber jsparber mentioned this issue Apr 18, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs discussion Needs discussion on how to implement or fix the corresponding task new api This requires adding API to an existing portal portal: notifications Notifications portal
Projects
Triage
Status: Triaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement v2 notification spec jsparber/xdg-desktop-portal
7 participants
@fmuellner @TingPing @GeorgesStavracas @matthiasclasen @kbroulik @ZanderBrown @Mikenux