Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable pytest and gets complained by missing python (Python is installed). #1547

Closed
lidgnulinux opened this issue Dec 23, 2024 · 1 comment · Fixed by #1548
Closed

Disable pytest and gets complained by missing python (Python is installed). #1547

lidgnulinux opened this issue Dec 23, 2024 · 1 comment · Fixed by #1548
Labels
bug

Comments

@lidgnulinux
Copy link

Operating System

Dragora GNU/Linux.

XDG Desktop Portal version

Other

XDG Desktop Portal version (Other)

1.19.1

Desktop Environment

Other

Desktop Environment (Other)

sway

Expected Behavior

The build run just fine.

Current Behavior

I want to build 1.19.1 version and disable pytest option. I'm facing an error where the build can't find python3 (I have python3). The error says Program python3 found: NO (disabled by: pytest ) followed by this :

../tests/meson.build:288:18: ERROR: Unknown method "language_version" in object <[ExternalProgramHolder] holds [NonExistingExternalProgram]: <NonExistingExternalProgram 'nonexistingprogram' -> [None]>> of type ExternalProgramHolder.

Any clue to fix it ? thanks.

Steps to Reproduce

  1. Build the 1.19.1 version.
  2. The build complaining about Program python3 found: NO (disabled by: pytest ) followed by :
../tests/meson.build:288:18: ERROR: Unknown method "language_version" in object <[ExternalProgramHolder] holds [NonExistingExternalProgram]: <NonExistingExternalProgram 'nonexistingprogram' -> [None]>> of type ExternalProgramHolder.

Anything else we should know?

I have meson log, meson-log.txt .
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 23, 2024
@lidgnulinux
Copy link
Author

Tried 1.19.0 version and the build went successful.

swick added a commit to swick/xdg-desktop-portal that referenced this issue Dec 23, 2024
@swick
build/tests: Check for python found and version in single require call
542d509 
We can only use the python object if it was found and the arguments for
require are all evaluated, even if the resulting feature is disabled.

Fixes: 1c6dd18 ("tests: Check for required WAV decoder for notification tests")
Closes: flatpak#1547
@swick swick mentioned this issue Dec 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 7, 2025
@swick @GeorgesStavracas
build/tests: Check for python found and version in single require call
cb16d56 
We can only use the python object if it was found and the arguments for
require are all evaluated, even if the resulting feature is disabled.

Fixes: 1c6dd18 ("tests: Check for required WAV decoder for notification tests")
Closes: #1547
@github-project-automation github-project-automation bot moved this from Needs Triage to Triaged in Triage Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
No open projects
Triage
Status: Triaged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build/tests: Check for python found and version in single require call swick/xdg-desktop-portal
1 participant
@lidgnulinux