Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodi remote popup and rgb popup needs adjustments #13

Open
xztraz opened this issue Feb 19, 2018 · 22 comments
Open

Kodi remote popup and rgb popup needs adjustments #13

xztraz opened this issue Feb 19, 2018 · 22 comments

Comments

@xztraz
Copy link
Contributor

xztraz commented Feb 19, 2018

Kodi remote control size is a bit small..

image

@xztraz xztraz changed the title Kodi remote popup borken Kodi remote popup and rgb popup needs adjustments Feb 19, 2018
@xztraz
Copy link
Contributor Author

xztraz commented Feb 19, 2018

RGBW popup.
white and brightness sliders in pop-up overlap with text. Maybe this is a base css bug. they'we changed stuff there recently

image

@xztraz
Copy link
Contributor Author

xztraz commented Feb 19, 2018

i think you can just add a non existing kodi in hardware and get the remote popup to test with.

@flatsiedatsie
Copy link
Owner

Are you on the latest version of the theme? Because the theme no longer tries to interfere with remote control positioning and size.

@xztraz
Copy link
Contributor Author

xztraz commented Feb 22, 2018

Jupp tried now again after updating to latest theme and domoticz as latest. tried in opera(webkit) and firefox.

image

@xztraz
Copy link
Contributor Author

xztraz commented Feb 22, 2018

if turning of center popups it looks like this instead (wider popup but only like one text row high)
image

@flatsiedatsie
Copy link
Owner

Could you try this?

  • Go to theme settings
  • Add user css:

#dialog-lmsplayer-remote,
#dialog-heosplayer-remote,
#dialog-media-remote{
min-height:300px;
}

@xztraz
Copy link
Contributor Author

xztraz commented Feb 24, 2018

same thing. tested in firefox and opera

image

image

fresh git pull of skin

@xztraz
Copy link
Contributor Author

xztraz commented Feb 25, 2018

if i change the min height in inspect element in browser on dialog-media-remote then it gets larger. doesn't the custom css bite?

image

@flatsiedatsie
Copy link
Owner

try:

#dialog-lmsplayer-remote,
#dialog-heosplayer-remote,
#dialog-media-remote{
min-height:400px!important;
padding: 0 20px 0 20px;
}

@xztraz
Copy link
Contributor Author

xztraz commented Feb 25, 2018

i found some auto height in a css if uncomented the controls show again but not sure other stuff may brake. ill try the css mods first

@xztraz
Copy link
Contributor Author

xztraz commented Feb 25, 2018

Hah! it works!
image

@xztraz
Copy link
Contributor Author

xztraz commented Feb 25, 2018

only thing if having center popup unchecked the control gets bigger and cant fit the box
image

@flatsiedatsie
Copy link
Owner

I cannot create a remote popup here unfortunately. Could you possibly take a screenshot of the html structure (right mouse button ->inspect)?

center_popups.css only has one css item in it:

.ui-dialog,
.ui-popup{
height:auto!important;
width:auto!important;
position:fixed!important;
top:50vh!important;
left:50%!important;
transform: translate(-50%, -50%)!important;
min-height:200px!important;
min-width:200px!important;
}

So if it affects the remote popup, that would imply that the remote popup also gets the ui-popup class somewhere. If I know how they are relate, I could write an exception in the css to not give a min-width to remotes.

@xztraz
Copy link
Contributor Author

xztraz commented Feb 26, 2018

on todays version of skin with this css added (might be an older cache thou so have that in mind)
image

with centered popups
image

no centering
image

@flatsiedatsie
Copy link
Owner

OK, so in the second picture, looking at the applied CSS in the right column, I see very little influence of the Aurora theme, and none that could explain the cut-off. Perhaps that's in the "dialog-media-remote" div inside it.

In theory, if you disable the theme's centering option, Domoticz' own methods of positioning should take over. It uses javascript to position and size things. This can be seen at the top of that column, in the 'element-stlyle' part. So unless we find some styling on the "dialog-media-remote" div, could it be that this is just normal Domoticz behaviour?

@xztraz
Copy link
Contributor Author

xztraz commented Mar 1, 2018

oh i might have selected the wrong item for inspect. Before i applied the aurora theme i used the remote quite often and then the scaling and frame was ok. you don't have the possibility to set up a kodi install to try out the remote?

@flatsiedatsie
Copy link
Owner

I don't have that possibility (I've tried). Domoticz doesn't allow you to fake a remote.

@xztraz
Copy link
Contributor Author

xztraz commented Apr 30, 2018

Ah. how can i help? :) i think the buttons aren't working either when the frame is fudged. i guess an image map that gets upset or something.

@flatsiedatsie
Copy link
Owner

I suspect the best bet is to try and not interfere with how Domoticz does things. It uses javascript to position and scale things. If you can find the CSS form the theme that 'gets in the way', then we can remove it.

@xztraz
Copy link
Contributor Author

xztraz commented May 3, 2018

image
this is how it looks in inspect

@xztraz
Copy link
Contributor Author

xztraz commented May 5, 2018

i've tried disabling all style rows but to no avail.. but found out that you can add a dummy device.

Add hardware "Kodi Media Server"
Push setup and add a dummy device. any ip will do. push add.
go to devices page. add kodi device.
go to switches. push on button(leftmost button)
now you have the remote to play with.

@flatsiedatsie
Copy link
Owner

@Xtraz I tried it again, but that sequence doesn't work for me. clicking the left most button doesn't launch the pop-up.

@2bbe 2bbe mentioned this issue Jan 12, 2019
M-M3on added a commit to M-M3on/domoticz-aurora-theme that referenced this issue Nov 14, 2020
flatsiedatsie added a commit that referenced this issue Nov 25, 2020
#62 fix wrong boxsizing & #13,#46 fix rgb popup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants