From 1bf2c84c66f43c0be1d5bc6969e1aa0141e37dda Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Fri, 24 Jan 2025 17:18:07 -0500 Subject: [PATCH] Update test to use a class with a real constant name Otherwise PoolConfig fails to constantize "klass2". I don't think we care if we support classes that don't have real names. --- .../connection_handler_test.rb | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/activerecord/test/cases/connection_adapters/connection_handler_test.rb b/activerecord/test/cases/connection_adapters/connection_handler_test.rb index 5605a79c1673..9321cb64efdc 100644 --- a/activerecord/test/cases/connection_adapters/connection_handler_test.rb +++ b/activerecord/test/cases/connection_adapters/connection_handler_test.rb @@ -279,18 +279,19 @@ def test_connection_pools assert_equal([@pool], @handler.connection_pools) end - def test_a_class_using_custom_pool_and_switching_back_to_primary - klass2 = Class.new(Base) { def self.name; "klass2"; end } + class MyClass2 < Base + end - assert_same klass2.lease_connection, ActiveRecord::Base.lease_connection + def test_a_class_using_custom_pool_and_switching_back_to_primary + assert_same MyClass2.lease_connection, ActiveRecord::Base.lease_connection - pool = klass2.establish_connection(ActiveRecord::Base.connection_pool.db_config.configuration_hash) - assert_same klass2.lease_connection, pool.lease_connection - assert_not_same klass2.lease_connection, ActiveRecord::Base.lease_connection + pool = MyClass2.establish_connection(ActiveRecord::Base.connection_pool.db_config.configuration_hash) + assert_same MyClass2.lease_connection, pool.lease_connection + assert_not_same MyClass2.lease_connection, ActiveRecord::Base.lease_connection - klass2.remove_connection + MyClass2.remove_connection - assert_same klass2.lease_connection, ActiveRecord::Base.lease_connection + assert_same MyClass2.lease_connection, ActiveRecord::Base.lease_connection end class ApplicationRecord < ActiveRecord::Base