Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link cannot tap on MacOS #380

Closed
zhouzhuo810 opened this issue Jul 23, 2024 · 6 comments
Closed

link cannot tap on MacOS #380

zhouzhuo810 opened this issue Jul 23, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@zhouzhuo810
Copy link

Steps to Reproduce

  1. clone demo
  2. run
  3. input www.baidu.com
  4. press ctrl + mouse single tap

Environment

  • OS [macOS 14.2.1 (23C71)]
  • Flutter version [3.19.6]
  • Fleather version [1.16.0]

Logs

GestureRecognizer _getRecognizer(Node segment) {
    print(segment);
    if (_linkRecognizers.containsKey(segment)) {
      return _linkRecognizers[segment]!;
    }

    if (isDesktop || widget.readOnly) {
      _linkRecognizers[segment] = TapGestureRecognizer(
        supportedDevices: {
          PointerDeviceKind.stylus,
          PointerDeviceKind.trackpad,
          PointerDeviceKind.mouse,
          PointerDeviceKind.invertedStylus,
        }
      )
      ..onTapCancel = () {
        print("777");
      }
      ..onSecondaryTap = () {
        print("4444");
      }
      ..onTapUp = (details) {
        print("222");
      }
      ..onTapDown = (details) {
        print("3333");
      }
        ..onTap = () => _tapLink(segment);
      print('111');
    } else {
      _linkRecognizers[segment] = LongPressGestureRecognizer()
        ..onLongPress = () => _longPressLink(segment);
    }
    return _linkRecognizers[segment]!;
  }

log :

flutter: ⟨www.baiduc.om⟩a
flutter: 111
flutter: ⟨www.baiduc.om⟩a
@zhouzhuo810
Copy link
Author

image

the first one link can tap

the second link can not tap

@zhouzhuo810
Copy link
Author

some times can tap , some times can not tap

@zhouzhuo810
Copy link
Author

and todo some times can not check

@zhouzhuo810
Copy link
Author

[1.14.4](fleather: ^1.14.4)

is work well

My code is the newest code

and I changed below:

image

because my flutter version is 3.19.6

@zhouzhuo810
Copy link
Author

It is the same result on Android.

@Amir-P

@amantoux
Copy link
Member

@zhouzhuo810 this was fixed with #399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants