Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap migrations in transaction #52

Open
Scimonster opened this issue Jun 3, 2019 · 3 comments · May be fixed by #56
Open

Wrap migrations in transaction #52

Scimonster opened this issue Jun 3, 2019 · 3 comments · May be fixed by #56

Comments

@Scimonster
Copy link

Each migration should ideally run in a transaction, to avoid a situation of a migration being partially applied.
@Scimonster Scimonster linked a pull request Jun 17, 2019 that will close this issue
Open
@PaulMest
Copy link

I like this suggestion. One thing to note, though, is that while this is possible with Postgres, it may not be supported on other popular RDBMS platforms.

@Scimonster
Copy link
Author

Scimonster commented Jun 24, 2019 via email

@PaulMest
Copy link

Looks like MySQL just started supporting Atomic DDL in 8.0. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap migration in transaction Scimonster/sequelize-auto-migrations
2 participants
@PaulMest @Scimonster