Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sequelize >5.8.11 to fix vulnerability #63

Open
staadecker opened this issue Jul 11, 2019 · 7 comments
Open

Upgrade to sequelize >5.8.11 to fix vulnerability #63

staadecker opened this issue Jul 11, 2019 · 7 comments

Comments

@staadecker
Copy link

See : https://www.npmjs.com/advisories/1018

@goalia
Copy link

goalia commented Jul 23, 2019

Same issue here

@tsjohns9
Copy link

tsjohns9 commented Aug 3, 2019

Similiar to this, if you upgrade to the latest version of sequelize, this package will not work when you perform a migration. You will get something like the error below when running the migrate command
node ./node_modules/sequelize-auto-migrations/bin/makemigration.js --name tmp -x

/Users/tjohnson/Public/repos/scottsdale-event/node_modules/sequelize-auto-migrations/lib/migrate.js:452
let options = currentState[tableName].schema[df.path[2]];
                                                                ^
TypeError: Cannot read property 'undefined' of undefined
    at Object.parseDifference (/Users/tjohnson/Public/repos/scottsdale-event/node_modules/sequelize-auto-migrations/lib/migrate.js:452:65)
    at Object.<anonymous> (/Users/tjohnson/Public/repos/scottsdale-event/node_modules/sequelize-auto-migrations/bin/makemigration.js:78:23)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:743:3)
error Command failed with exit code 1.

@saulojoab
Copy link

Is there any alternative for this package?

@staadecker
Copy link
Author

Not that I'm aware of :(

@saulojoab
Copy link

Well, that sucks. I found this package which is pretty nice, it basically transforms your already existing database into models.

Sadly it doesn't auto update the DB when I change the models, but at least it's way better than doing things from ground zero.

@nvcken
Copy link

nvcken commented Aug 28, 2019

I got empty table's column in migration script when run makemigration, occurs in sequelize 5.8.11

        params: [
            "account",
            {

            },
            {}
        ]

@staadecker

@BugKiller-tech
Copy link

@nvcken did you solve this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants