-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows support (again) #32
Comments
Another possibility is a problem with arb/flint (or with the way that they are being built). There are lots of compiler warnings from building them on Windows with the build scripts here as discussed in #31. Under Windows I don't seem to be able to get MINGW64 /c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0
$ make check
make[1]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Nothing to be done for 'shared'.
make[1]: Leaving directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[2]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[2]: Nothing to be done for 'shared'.
make[2]: Leaving directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Leaving directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0/fmpr'
CC ../build/fmpr/test/t-add.exe
CC ../build/fmpr/test/t-add_naive.exe
CC ../build/fmpr/test/t-cmp.exe
CC ../build/fmpr/test/t-cmp_2exp_si.exe
CC ../build/fmpr/test/t-cmpabs.exe
CC ../build/fmpr/test/t-cmpabs_2exp_si.exe
CC ../build/fmpr/test/t-div.exe
CC ../build/fmpr/test/t-exp.exe
CC ../build/fmpr/test/t-expm1.exe
CC ../build/fmpr/test/t-get_d.exe
CC ../build/fmpr/test/t-get_fmpz.exe
CC ../build/fmpr/test/t-get_mpfr.exe
CC ../build/fmpr/test/t-log.exe
CC ../build/fmpr/test/t-log1p.exe
CC ../build/fmpr/test/t-mul.exe
CC ../build/fmpr/test/t-mul_fmpz.exe
CC ../build/fmpr/test/t-mul_naive.exe
CC ../build/fmpr/test/t-mul_si.exe
CC ../build/fmpr/test/t-mul_ui.exe
CC ../build/fmpr/test/t-normalise.exe
CC ../build/fmpr/test/t-root.exe
CC ../build/fmpr/test/t-rsqrt.exe
CC ../build/fmpr/test/t-set_fmpq.exe
CC ../build/fmpr/test/t-set_fmpz_2exp.exe
CC ../build/fmpr/test/t-set_round_mpn.exe
CC ../build/fmpr/test/t-set_round_ui_2exp_fmpz.exe
CC ../build/fmpr/test/t-set_round_uiui_2exp_fmpz.exe
CC ../build/fmpr/test/t-sqrt.exe
CC ../build/fmpr/test/t-sub.exe
CC ../build/fmpr/test/t-ulp.exe
make[1]: *** [../Makefile.subdirs:84: ../build/fmpr/test/t-add.exe_RUN] Error 127
make[1]: Leaving directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0/fmpr'
make: *** [Makefile:168: check] Error 2 The exe files are generated: $ ls build/fmpr/test/
t-add.exe t-div.exe t-log.exe t-mul_ui.exe t-set_round_mpn.exe
t-add.exe.d t-div.exe.d t-log.exe.d t-mul_ui.exe.d t-set_round_mpn.exe.d
t-add_naive.exe t-exp.exe t-log1p.exe t-normalise.exe t-set_round_ui_2exp_fmpz.exe
t-add_naive.exe.d t-exp.exe.d t-log1p.exe.d t-normalise.exe.d t-set_round_ui_2exp_fmpz.exe.d
t-cmp.exe t-expm1.exe t-mul.exe t-root.exe t-set_round_uiui_2exp_fmpz.exe
t-cmp.exe.d t-expm1.exe.d t-mul.exe.d t-root.exe.d t-set_round_uiui_2exp_fmpz.exe.d
t-cmp_2exp_si.exe t-get_d.exe t-mul_fmpz.exe t-rsqrt.exe t-sqrt.exe
t-cmp_2exp_si.exe.d t-get_d.exe.d t-mul_fmpz.exe.d t-rsqrt.exe.d t-sqrt.exe.d
t-cmpabs.exe t-get_fmpz.exe t-mul_naive.exe t-set_fmpq.exe t-sub.exe
t-cmpabs.exe.d t-get_fmpz.exe.d t-mul_naive.exe.d t-set_fmpq.exe.d t-sub.exe.d
t-cmpabs_2exp_si.exe t-get_mpfr.exe t-mul_si.exe t-set_fmpz_2exp.exe t-ulp.exe
t-cmpabs_2exp_si.exe.d t-get_mpfr.exe.d t-mul_si.exe.d t-set_fmpz_2exp.exe.d t-ulp.exe.d The generated files all give exit code 127: $ for exe in *.exe; do echo $exe; ./$exe; echo $?; done
t-add.exe
127
t-add_naive.exe
127
... Running under
I think the problem is that on Windows it is I'm now running the Arb tests locally... $ export ARB_TEST_MULTIPLIER=0.1
pc@NUCPC MINGW64 /c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0
$ make check
make[1]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Nothing to be done for 'shared'.
make[1]: Leaving directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[2]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[2]: Nothing to be done for 'shared'.
make[2]: Leaving directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Leaving directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0'
make[1]: Entering directory '/c/Users/pc/src/flint/python-flint/.local/src/arb-2.23.0/fmpr'
add....PASS
add_naive....PASS
cmp....PASS
cmp_2exp_si....PASS
... |
Locally I can reproduce the doctest failures on Windows but so far it seems like Arb's That suggests that the problem is in python-flint rather than Arb. I've opened #33 to add |
This is a continuation of #10 after #28 fixed the basic problem reported there.
After #31 the doctests are running again in CI and many of them in acb and arb are failing on Windows.
There is one compiler warning when building python-flint that is also seen on Linux:
That is coming from this line here:
https://github.com/fredrik-johansson/python-flint/blob/71d16124fb241e3c4a62267a11d6842478e420b3/src/flint/dirichlet.pyx#L98
Specifically the comparison comes from
max(q, 2)
and is becauseq
isulong
where as cython decides to make 2 be a signedlong
. Perhaps that is a bug in cython itself. It seems unlikely that it would cause any significant problems though since bothq
and2
will always be positive.The other errors are all from
acb
andarb
:The text was updated successfully, but these errors were encountered: