You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently VajramKryonGraph.validateMandatory is taking ~10% of the CPU of Kryon.executeMainLogicIfPossible. Most of this time is going in Stream processing and iteration.
I idea is to move this validation into auto-generated vajram models code so that we can omit iteration and stream processing. Instead we can custom generate a validation method which access each input explicitly. This way we can avoid Inputs.getInputValue lookup as well.
The text was updated successfully, but these errors were encountered:
RamAnvesh
changed the title
Move VajramKryonGraph.validateMandatory from VajramKryonGraph to auto-generated code
Move VajramKryonGraph.validateMandatory from VajramKryonGraph to auto-generated code #Vajram
Aug 15, 2023
In the new Krystal 9 design, stream has been replaced with for loop and map lookup is completely eliminated as we are using a code generated lambda to get the facet value. So this performance problem should be solved. We are seeing some gains in benchmarks as well. Closing this issue. Fresh profiling will be needed to find new bottlenecks in the new design.
Currently
VajramKryonGraph.validateMandatory
is taking ~10% of the CPU ofKryon.executeMainLogicIfPossible
. Most of this time is going in Stream processing and iteration.I idea is to move this validation into auto-generated vajram models code so that we can omit iteration and stream processing. Instead we can custom generate a validation method which access each input explicitly. This way we can avoid
Inputs.getInputValue
lookup as well.The text was updated successfully, but these errors were encountered: