Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#RunAllRuntimeVajramValidationsDuringBuildTime Add support validating the vajram post code generation phase #246

Open
RamAnvesh opened this issue May 8, 2024 · 1 comment
Labels
good first issue Good for newcomers size: m Medium sized change validation
Milestone

Comments

@RamAnvesh
Copy link
Collaborator

A vajram can have atmost one fanout resolver per dependency
The vajram gradle plugin should load the vajrams in the module, create the graph and perform the validation, else fail build.

@RamAnvesh RamAnvesh added this to the v9 milestone Feb 2, 2025
@RamAnvesh RamAnvesh added good first issue Good for newcomers size: m Medium sized change labels Feb 6, 2025
@RamAnvesh
Copy link
Collaborator Author

RamAnvesh commented Feb 6, 2025

This is not possible to do this in annotation processing phase because not all resolvers are defined using the resolve annotation. There are simple input resolvers written using the direct syntax. The only way to figure out all the resolvers defined in a vajram is to load the vajram classes and create vajrams/vajram metadata objects. These objects constructors already have the validations defined.

What this means is that we don't need to implement anything specific for validating the number of fanout resolvers as per is this issue. All we have to do is implement a way to create all vajrams as part of the build step. This should cover all validations and even future validations added to vajram metadata class.

Changing the issue title to reject this generic scope of this issue

@RamAnvesh RamAnvesh changed the title #MaxOneFanoutResolverPerDependency Add support validating the vajram post code generation phase #RunAllRuntimeVajramValidationsDuringBuildTime Add support validating the vajram post code generation phase Feb 6, 2025
@RamAnvesh RamAnvesh marked this as a duplicate of #155 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers size: m Medium sized change validation
Projects
None yet
Development

No branches or pull requests

1 participant