comments resolve

Author: Mitul0911

build.gradle

@@ -27,7 +27,7 @@ tasks.withType(GenerateModuleMetadata) {
 	enabled = false
 }
 
-def gJEXVersion = '1.43-SNAPSHOT-3'
+def gJEXVersion = '1.43-SNAPSHOT-4'
 def grpcVersion = '1.60.0'
 def jacksonVersion = '2.16.1'
 def guiceVersion = '5.1.0'

core/src/main/java/com/flipkart/gjex/core/filter/grpc/AccessLogGrpcFilter.java

@@ -148,7 +148,7 @@ public void doHandleException(Exception e) {
     public GrpcFilter configure(GrpcFilterConfig grpcFilterConfig) {
         if (grpcFilterConfig.isEnableAccessLogs()){
             AccessLogGrpcFilter accessLogGrpcFilter = new AccessLogGrpcFilter();
-            if (org.apache.commons.lang.StringUtils.isNotBlank(grpcFilterConfig.getAccessLogFormat())){
+            if (org.apache.commons.lang.StringUtils.isNotEmpty(grpcFilterConfig.getAccessLogFormat())){
                 AccessLogGrpcFilter.setFormat(grpcFilterConfig.getAccessLogFormat());
             }
             return accessLogGrpcFilter;

guice/build.gradle

@@ -61,6 +61,8 @@ dependencies {
     implementation libraries.hystrix_metrics_stream
     implementation libraries.rxjava2
 
+    implementation group: 'org.apache.commons', name: 'commons-collections4', version: '4.0'
+
     implementation 'org.eclipse.jetty:jetty-server:9.4.56.v20240826'
     implementation 'org.eclipse.jetty:jetty-servlet:9.4.56.v20240826'
     implementation 'org.eclipse.jetty:jetty-webapp:9.4.56.v20240826'

guice/src/main/java/com/flipkart/gjex/grpc/interceptor/FilterInterceptor.java

@@ -36,6 +36,7 @@
 import io.grpc.ServerInterceptor;
 import io.grpc.Status;
 import io.grpc.StatusRuntimeException;
+import org.apache.commons.collections4.CollectionUtils;
 
 import javax.inject.Named;
 import javax.inject.Singleton;
@@ -44,6 +45,7 @@
 import java.net.SocketAddress;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -226,7 +228,7 @@ private void detachContext(Context currentContext, Context previousContext) {
 
     private void addAllStaticFilters(GrpcFilterConfig grpcFilterConfig, List<GrpcFilter> filtersForMethod, Map<Class<?>, GrpcFilter> classToInstanceMap) throws ClassNotFoundException {
         List<String> filterClasses = grpcFilterConfig.getFilterClasses();
-        if (filterClasses != null && !filterClasses.isEmpty()) {
+        if (CollectionUtils.isNotEmpty(filterClasses)) {
             for (String filterClass : filterClasses) {
                 try {
                     Class<?> clazz = Class.forName(filterClass);