Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topic-level Producer Metrics to Metrics Emitter #231

Open
anuj-flipkart opened this issue Feb 12, 2025 · 3 comments
Open

Add Topic-level Producer Metrics to Metrics Emitter #231

anuj-flipkart opened this issue Feb 12, 2025 · 3 comments
Assignees
Milestone

Comments

@anuj-flipkart
Copy link
Collaborator

anuj-flipkart commented Feb 12, 2025

Description

This task involves implementing comprehensive producer metrics for Varadhi. These metrics are crucial for monitoring message production, system health, performance characteristics, and identifying potential issues at scale.

Key Requirements

  • Implement metrics for the following categories:

    • Message Production Metrics (counts, rates, latencies)
    • Throughput and Volume Metrics (byte-level, rate metrics)
    • Resource Utilization Metrics (memory, thread/connection metrics)
    • Storage Layer Metrics (performance, partition metrics)
    • Client Interaction Metrics (client health, rate limiting/quotas)
    • HTTP API Metrics (request/response metrics)
  • Utilize the specified metric types (Counter, Gauge, Timer, DistributionSummary).

  • Include the specified percentile breakdowns for latency metrics (p50, p75, p90, p95, p99, p99.9 for producer latency; p50, p95, p99, p999 for HTTP API latency).

  • Implement the defined metric tags for categorization (topic, region, client_id, partition, error_type, storage_type, operation, message_type).

  • Implement the error type classifications and correlation.

  • Ensure all metrics are correctly unitized (messages, bytes, milliseconds, etc.).

Success Criteria

  • All metrics are implemented and functioning correctly.
  • Metrics are exposed in a way that can be easily monitored and visualized.
  • Metrics are accurately tagged and categorized for easy filtering and analysis.
  • Error classifications and correlations are correctly implemented.
  • Unit tests are in place to ensure the correctness of the metric implementation.

References

Documentation: Varadhi OSS Producer Metrics Doc

Acceptance Criteria

  • Verify that all metrics are being collected.
  • Check that the metrics values are as expected under load.
  • Ensure the correct tags are being applied to metrics.
  • Simulate different error conditions to verify the error metrics and tags.
@anuj-flipkart
Copy link
Collaborator Author

anuj-flipkart commented Feb 14, 2025

Task
2. What are the produce matrix in Varadhi
3. Create comparison against Varadhi OSS

@anuj-flipkart
Copy link
Collaborator Author

Grooming target: Sprint 130

@devanshu-garg-IN devanshu-garg-IN changed the title Export Topic level standard produce metrics. No compatibility needed with internal-vrd Add Topic-level Producer Metrics to Metrics Emitter Feb 21, 2025
@devanshu-garg-IN devanshu-garg-IN moved this from Todo to In Progress in Varadhi Mar 3, 2025
@anuj-flipkart
Copy link
Collaborator Author

Task breakdown is pending. ETA: 06 March 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants