From 2bbdd4a4fb56b0832e7f1934961d383d71b8c40d Mon Sep 17 00:00:00 2001 From: Petrus Asikainen Date: Wed, 8 May 2024 19:39:39 +0300 Subject: [PATCH] Fix Reference & Manager compatibility with React 18's StrictMode (#459) --- src/Manager.js | 1 + src/Reference.js | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Manager.js b/src/Manager.js index 2c5d781..f3f03f6 100644 --- a/src/Manager.js +++ b/src/Manager.js @@ -15,6 +15,7 @@ export function Manager({ children }: ManagerProps): React.Node { const hasUnmounted = React.useRef(false); React.useEffect(() => { + hasUnmounted.current = false; return () => { hasUnmounted.current = true; }; diff --git a/src/Reference.js b/src/Reference.js index 81cd115..9eb9cc6 100644 --- a/src/Reference.js +++ b/src/Reference.js @@ -22,10 +22,6 @@ export function Reference({ children, innerRef }: ReferenceProps): React.Node { [innerRef, setReferenceNode] ); - // ran on unmount - // eslint-disable-next-line react-hooks/exhaustive-deps - React.useEffect(() => () => setRef(innerRef, null), []); - React.useEffect(() => { warning( Boolean(setReferenceNode),