Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic fixing ignores justifications #288

Open
pvogt09 opened this issue Apr 11, 2024 · 2 comments
Open

Automatic fixing ignores justifications #288

pvogt09 opened this issue Apr 11, 2024 · 2 comments
Labels
component: core Affects the core infrastructure difficulty: high This change will be tricky or large tool: mh_style Affects the style checker tool

Comments

@pvogt09
Copy link

pvogt09 commented Apr 11, 2024

MISS_HIT Component affected
Please choose one from:

  • Style checker

Your MATLAB/Octave environment

  • MATLAB
  • R2023B

Your operating system and Python version

  • Linux
  • python 3.8.10

Describe the bug
Running the style checker with the autofix option and default configuration on

% symblic derivation
xdot % mh:ignore_style
y % mh:ignore_style
dzdx = jacobian(xdot, x) % mh:ignore_style
dzdu = jacobian(xdot, u) % mh:ignore_style
dzdmv = jacobian(xdot, u(1)) % mh:ignore_style
dydx = jacobian(y, x) % mh:ignore_style

fixes this file to

% symblic derivation
xdot; % mh:ignore_style
y; % mh:ignore_style
dzdx = jacobian(xdot, x); % mh:ignore_style
dzdu = jacobian(xdot, u); % mh:ignore_style
dzdmv = jacobian(xdot, u(1)); % mh:ignore_style
dydx = jacobian(y, x); % mh:ignore_style

by adding a semicolon to every line that was supposed to be ignored. The style checker without autofix option does not complain about the missing semicola though.

@florianschanda florianschanda added tool: mh_style Affects the style checker tool component: core Affects the core infrastructure labels Jul 8, 2024
@florianschanda
Copy link
Owner

I have to admit, I did not consider this use-case.

@florianschanda florianschanda added the difficulty: high This change will be tricky or large label Aug 15, 2024
@florianschanda
Copy link
Owner

I looked into this and the mechanism to do that would require a rewrite in how justifications are done. Tagging it high complexity for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Affects the core infrastructure difficulty: high This change will be tricky or large tool: mh_style Affects the style checker tool
Projects
None yet
Development

No branches or pull requests

2 participants