Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unixify user interface #38

Closed
flosell opened this issue Apr 8, 2018 · 1 comment
Closed

Unixify user interface #38

flosell opened this issue Apr 8, 2018 · 1 comment

Comments

@flosell
Copy link
Owner

flosell commented Apr 8, 2018

Currently, the CLI interface is organized around a very specific workflow and is convenient if you are using that specific workflow. Everything that's not that workflow is hard (e.g. generating a policy for a very specific selection of events, only fetching and printing certain events and then post-processing them with another tool (e.g. jq)).

For this reason, it would be nice if the trailscraper commands behaved more according to the Unix philosophy and only do one thing.

Proposal:

trailscraper generate-policy --from "one day ago" becomes trailscraper select --from "one day ago" | trailscraper generate

Concerns:

Performance impact of piping?

flosell added a commit that referenced this issue May 1, 2018
flosell added a commit that referenced this issue May 1, 2018
flosell added a commit that referenced this issue May 1, 2018
@flosell
Copy link
Owner Author

flosell commented May 1, 2018

Done. Piping has a performance impact but is ok when traded off against the flexibility of the interface . Created #44 to work on inefficiencies.

@flosell flosell closed this as completed May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant