Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive diffing? #3

Open
jonnor opened this issue Jul 9, 2016 · 1 comment
Open

Interactive diffing? #3

jonnor opened this issue Jul 9, 2016 · 1 comment
Labels

Comments

@jonnor
Copy link
Collaborator

jonnor commented Jul 9, 2016

Visual diffing (#2) will likely have some challenges in showing the details of a change. Complimenting it with text-based diffing is one possibility, but is not a very integrated experience.

Since the graphs are often created using an interactive editor, would be nice to be able to also do diffing there and make use all the regular tools for navigating/showing/hiding information.
Ideally the tool would be capable enough that it can also be used to pick changes from a diff, for instance to resolve a merge conflict.

@jonnor jonnor added the question label Jul 9, 2016
@jonnor
Copy link
Collaborator Author

jonnor commented Jul 9, 2016

Since we already have web-enabled interactive tools (like https://app.flowhub.io) it could possibly be easier to embed those for side-by-side visual diffing than to. For instance, one could use Flowtrace support by generating a trace which just has the graphs (no events), and then specify this via a app.flowhub.io....trace=someurl.
But maybe at that point, the entire diff concept should be supported there, and just be able to specify a URL with source/destination graphs...

However, it is likely that Github PRs does not allow iframes inline, so would have to be a link/image one clicks on to open. Which is a bit tediuos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant