Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addNode, addEdge, addInitial should check existing data before adding #19

Open
bergie opened this issue Aug 19, 2018 · 2 comments
Open

addNode, addEdge, addInitial should check existing data before adding #19

bergie opened this issue Aug 19, 2018 · 2 comments

Comments

@bergie
Copy link
Member

bergie commented Aug 19, 2018

Now calling addEdge multiple times with same data causes edge to be duplicated.
@jonnor
Copy link

jonnor commented Aug 19, 2018

@bergie Silently ignoring this case might hide bugs in API consumer. So I think it should error...

@bergie
Copy link
Member Author

bergie commented Aug 19, 2018

Right now that would mean throwing. Or should we do major bump and make everything do Promises?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bergie @jonnor