Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use schemas to validate messages #14

Open
chadrik opened this issue May 24, 2016 · 1 comment
Open

tests: use schemas to validate messages #14

chadrik opened this issue May 24, 2016 · 1 comment
Labels
enhancement

Comments

@chadrik
Copy link
Contributor

chadrik commented May 24, 2016

The tests validate two aspects of messages sent from the runtime: their structure and their values. We should replace all the structural tests with validation against the schema files. This looks to be the most popular json-schema validator for node: https://www.npmjs.com/package/jsonschema

Requires #13
@ifitzpatrick ifitzpatrick mentioned this issue Jun 1, 2016
Merged
@chadrik
Copy link
Contributor Author

chadrik commented Jun 21, 2016

@ifitzpatrick, is this resolved now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnor @chadrik