Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for Ruby Env #14

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Initial commit for Ruby Env #14

merged 6 commits into from
Oct 28, 2024

Conversation

stahnma
Copy link
Contributor

@stahnma stahnma commented Oct 16, 2024

No description provided.

@floxbot floxbot added the team-content Issues to be picked up by @flox/team-content label Oct 16, 2024
@garbas
Copy link
Contributor

garbas commented Oct 22, 2024

@stahnma I've made the ruby environment more minimal, I know this is now what you intended when you created this environment. Just like I did with other environments.

I'm trying to keep each environment similar to one another in terms of scope and functionality. I'm all open to changing that, but maybe this would be a job for another PR.

I've added a review on this repo, if you think changes are somewhat ok (we can always change them) please go ahead and merge this PR.

@garbas garbas self-requested a review October 22, 2024 19:49
@stahnma
Copy link
Contributor Author

stahnma commented Oct 25, 2024

Basically, if you need to run gem install or bundle you want several of those C Extensions.

If we add gum and which (which are totally not needed for ruby), why wouldn't we pick the the things you do need for ruby?

These are the ones that I would really pick by default.

gcc-unwrapped.pkg-path = "gcc-unwrapped"
libxml2.pkg-path = "libxml2"
libxslt.pkg-path = "libxslt"
gnumake.pkg-path = "gnumake"
binutils.pkg-path = "binutils"
pkg-config.pkg-path = "pkg-config"
glibc.pkg-path = "glibc"  # glibc only needed on linux builds
glibc.systems = [ "x86_64-linux" , "aarch64-linux"]
openssl.pkg-path = "openssl"
libyaml.pkg-path = "libyaml"

@garbas garbas merged commit ba7fe47 into main Oct 28, 2024
7 checks passed
@garbas garbas deleted the addruby branch October 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-content Issues to be picked up by @flox/team-content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants