Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary wheels to releases uploaded to PyPI #39

Open
itamarst opened this issue Dec 8, 2023 · 3 comments
Open

Add binary wheels to releases uploaded to PyPI #39

itamarst opened this issue Dec 8, 2023 · 3 comments

Comments

@itamarst
Copy link

itamarst commented Dec 8, 2023

If you have some free time, using https://cibuildwheel.readthedocs.io/en/stable/ it's not too difficult to build binary wheels for Linux/macOS/Windows. It has support for GitHub Actions. This would make it easier for users to install.

@flozz
Copy link
Owner

flozz commented Dec 12, 2023

Hello,

I started modernizing the dev tools of the lib. I will add a workflow to build wheels and to publish them to PyPI.

@flozz
Copy link
Owner

flozz commented Dec 13, 2023

I was able to build wheels for Linux, there were Errors on Windows and macOS:

image

On Windows it seems to be an encoding issue:

       File "C:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.6.8\tools\lib\encodings\cp1252.py", line 23, in decode
        return codecs.charmap_decode(input,self.errors,decoding_table)[0]
    UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 1753: character maps to <undefined>

https://github.com/flozz/pypapi/actions/runs/7194943216/job/19596558002

And on macOS it seems to be an implecite declaration of a function (in papi?):

    darwin-common.c:108:3: error: implicit declaration of function 'sysctlnametomib' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      sysctlnametomib("machdep.cpu.vendor", mib, &len);
      ^
    darwin-common.c:111:7: error: implicit declaration of function 'sysctl' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      if (sysctl(mib, 3, &buffer, &len, NULL, 0) == -1) {
          ^

https://github.com/flozz/pypapi/actions/runs/7194943216/job/19596558316


I have no time to fix this, so I will release wheels for Linux only, and Windows / macOS will be added if someone make a PR to fix the builds on those platforms ^^'

@itamarst
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants