Instacrash when fittransform-ing in fluid.umap~

[rconstanzo]

I remember this being an issue a while back but it being fixed (hence the fluid.umap~: Number of Neighbours is larger than dataset error message now when trying to fittransform something that has fewer dimensions than @numneighbours) but there appears to have been an oversight when coding it as it gives a nice instacrash when fittransform-ing a dataset with the same amount of dimensions as @numneighbours.

patch.zip

I imagine this means that a > needs to get changed to a >= when running the size check.

Also including three crash reports, two of which point to a gnarly UMAP error but the third one is different (no flucoma mention at all), so including it in case it's indicative of something else happening at the same time.

crash reports.zip

[lewardo]

I've managed to reproduce the bug, and got the stacktrace to a segfault in UMAP.hpp:373 in fluid::algorithm::UMAP::makeGraph, in the *nearestIds[pos] when discardFirst is set to true, the pos index goes out of bound on the last iteration of the for loop, possibly the boundary checks of the nearestIds doesnt check for overflow

[rconstanzo]

I don't know if something was changed with this in the update(s) since this, but this is much more prone to crashing now.

Between this issue and #278 it seemed like having not only the same number of dimensions as @neighbours will instacrash Max, also having less will prompt an instacrash. What's odd is that it appears to only happen with a smaller dataset. I haven't programmatically narrowed things down to see where this starts happening, but here's a patch that shouldn't crash, but certainly does.

At the moment I'm coding something based around small-ish datasets (~10-20 entries) and it's basically a dice roll every time I do it whether Max crashes or not based on this bug.

<pre><code>
----------begin_max5_patcher----------
1410.3ocuXssbaaCD8YouBV9rLGrKt2m7+QmNdnjPrYpDoFRpTmlI4auG.H4
HWeUJrNyDISvEXOmytXW.8s4yJW1ceXnr32K9ihYy917YyRCEGX1gmmUts99
UapGRlUtpa61P6X4h76FC2OlFWVUrqOLLTLdWnXUe8vcEK2ON109aGMcSSaX
U291j87gAa2usocSXLs3zgA2UOt5tl1auoOrZLCNxJqDKJjZYkdQg2jd.CU7
m+bg51OdbkDGFsYcBbcK+7Utx3Pee973GK9EYKGYaS6XQc65hU2EV8WECM+S
XRnJqsQ1QLG+xZOepZlRpRUEq2ucWw5lUiEq5ZGgQCkmImbIVvtLwRgRVbNT
ReITpM72XtOgQHOcW.wsMc0qOWhnSXmjour9DQ3WjHGWn7PiecWHuJkkOLgS
3HQWBIy6xtLdvo8Qr53mmKMVV2d6ySEQ4C9tudaXLzeSnsd4lzLESWrLkUdc
X6xv5B5YEA9sDAm+me9JwR8KIBQHzz0V2+0xEHxd5+eNogOhx00i0GH7AFOC
aB2jblawgAN0niVMqjxt9JRUYrRujHlbrgr7hhqDURsv5rZmPPR1h5kJekEa
6DRxPFlDdUxNEY0JuzRVxKMXHCWYjBiWKURAdo0snPTQjUHEJLFgOMoZRVkW
KTBmWp0JiOZ1CBG.He.fFjfIrdu1HfYtHVthpbj2iB5LwBMIwjM.yJqQobBs
W3XgLyCgPardV4sFoB1ckRWQZgPxQ3nArnnmkfpDaMZiR6cXHh7UZF+Iltzw
Nh0+WDJOfPTFRSZO4rPbbdkN6ZR4zdofkJHMPEPMYkKJDFsh8YlHpX3HGzOg
lspn1KIXlyEgKasPwNHfNnyNIhRQDEwGVNrNJfNaTtINamjcfEdKofbcBZUG
C3P77dDSsVukUXAynELkgj5YRqhZhmqbRo.Rp0JhYCIcR.fB9ngB5ojFKQ.m
P1CSRJFAzlDNbJLIozf3AovTstJGh1HRHrLCqRvEJNVXsFHRnr9Sfq9n3RUf
3LClhDOCPdBtBC9GjDKDbOcnetCYBBoSD08r5pTHvnjdVXPxaLkE0q.miobX
IsRiTlvAvC4sJjfwIkD4mZAizNuC5DBW9bvhYGBhNnTFi5D3ZNpt9JlEQw23
EQ4zlSCQfz4Yi.ISZFtzIqHr0x5kw7kTxELCRqyFAlOlwGQqCvPhjRGxUQrl
yKWbOjCAFrm.QGrbj.6mvJI7tGkM3LrA7G6aMLT2LZSkMSENyUQFp+RX8Mnv
BppcS83XeCZHjOR2oEVRUHOoVNNiR315Ue8j1suPs5m9xs0618nR4G.0GXiK
Ho+e04xN4ct1Csu+BaPmOhgV7FMm3W7fFKdMtp9f5R2CbEdzIjOuVzXKP7KC
8qHCOuDvWxYt1hK5Tea3I77RXHZGmNRoJQNoXRORoeJYW5FOmM8DoLXz4IQO
dRomcJo2mZP0y51gO00uMeC1WXW6altJ0YNSSKakS3cf9zl8Mqq1iR4+n3Z.
p0M3xeC3XrCEbw0aB08s80XOKZaVbcCJLTOldIN8Uw0PKV2LLhWpSStMzb6c
K612OTnuv54xzED046UMw6voIW2hmJeHL9iWMM4suEoSkuOrZ5I8kP43oG12
bjKwmN1+5mA3yko9T8LoOeye8zVcizu29WoYm9YY9O+XWIHGG+w5x.35pi9N
WHEGI6ALrNLL1zl1RbhMT1lmU4eu9w9A4G46wO7T3I983oovQwrgOHN8vp75
9xNIt583I0T3I5CJ2K9iC8lNhmBG8tRHdhixEKvkb9Rne3f0IefxketKUTzu
H8XSa9wzkjJ6Ceo4n84Qp6Q8vQTLbeeBWk2axG4tba25PeKp1FK5MOectxTo
3VTHaXWclHoJ1y+97+EvLUbUO
-----------end_max5_patcher-----------
</code></pre>

Max version 8.6.2
OSX 14.4.1
FluCoMa version 1.0.7

[rconstanzo]

Ok, narrowed it down.

Max will crash if you have a fluid.dataset~ with where size == @neighbours in fluid.umap~ OR if size =< 6.

For some reason if your fluid.dataset~ size is 6 or less, it will crash when trying to fittransform.

<pre><code>
----------begin_max5_patcher----------
1857.3ocyZssiapCE84Y9J7Ao91zHrMPf9TOeGsUQNAmD2xMYalNSqZ+1OFa
HAH.Cg.4LRiHC1F7Zu12rM6e+3CVaSegJr.eB7EvCO76Ge3AcSEM7P48OXES
dYWDQnGl0tz3XZhz5ISeR5KRc6vUfXxOnfv733WAgDIQPOMpHVBcWZdhdnnx
FSxiYIQTo98BKaLiH2cjkbXCmtSZvEzY8J6m.H2hqPaTwOX7Jav2N+hRykUu
I6xVYgZbkt86eDZUzzed7whKOMRAMg9S0ydgb9Q.zpKA.0u.r1WieOO8OAqb
UWQ8h+Jlvzj70Lp4sXwJnuucoz4LEoKlJDjCzKDuLN6rxcrBHxGq0MHGstQq
glhD1o3gsmj1KOdKkacslZv00TUt1ugff5UPdBXskjbnSABs15DB3jXpjx2P
SHaizOs87YpxU3hBDreQuVEZEOX9wCdK7P2bf+TTpaykxzjopTCzWcptdsFm
8qOcmc8YCi2mI7D0q8FLqQFKYezRZUiGhEp.mf7LMbCQJ4Lkxjd9+DkzQIeT
H0Q4zz8UMW0d8WOKgIYjHC57p.UWC4RjzZTOyDrAFPTZxgt0AMFVbZn5OZsr
PM5VbLkKGwqohxwltzFOU+LOQFx.e0RmslzLe8WslXjhxP+P2IG6WGlpKCKX
fU8oWQYsrT1yhnOS4BlJzPM8mEIKqVyMMhhIeOU+hBNw+J40zzYUGmVXWXd9
ysR3JRPpXfbtQS9hmyY0XgA.OImogRkBrBRZESgEfHiry7vE5uptOSqtAlE6
nyC4.0jqy5ZK5Qo3ODkt6Gzv5fyJMilvRx3TgZMZDYKraER2Sxija1mlHMDt
BjE4t6n+8kHryNOYE+u7BOvpgbfyBSSJ.QCMQQyUSmxjw1Ha0EF8HRHYc7vJ
a.EszSmBkPlK1R30bfQUcJSSiZ10omKhtWV1cFKIoEKJSy5uSN6vwAd1sopN
iG5cq6QrIOwz6FkMgbSQfwliiDEU58170+BIgESjTIynBP1m5zDk6nXGOMJp
g7Z544N5ITYiui9SVn7ndhpaLnFNKqxHx5jVNjcfJjMaSRNHZ1hP9pgzq0T9
1Re3MRZbVjRJZN.k2ASHUwI+onbfUFZ0IfyaXotOc8PgMZuUHQcXsS9qsC0Y
Wqitxj5YbE09kX6pqmy8zW.u2XAuWtl9ZsWskq5Tkd7IgTsDipZqLUQUFhoP
OMxXzLqgTuVRv1dIO3vjWYxAyBPJWFBdPxCMD4YVXaqkjbwtGrlQtw.goJ99
5sA5XGLZaG6tkIzUYb.mQB3l7cvdyoqyfZc3+aLzftOro66.KO9CO+ZGhvM3
7n2k+awh1yp2y.TiPerC6AJ0D+0O9A1m.ef04e8ReAih9Ji8fbviH3yzhbCs
Q2IRiSRBSiUKjxtWVA8FrRfYYlAZipxioZIHEeu6Dmj+KFvapzgI.EDiMwoG
AafeyHTOc925meWaBZsychfBY6jqTa93G5s78IvtzHwm76kwviIkFFCMDm8s
Z.UfN0xMI7W6mof2Sl5.OMO61R3is0rS4o+tvji8chb1GkyBWUdpA+EbjFks
JUdr14Ybs42Z37Ac7u0UG13nGaySt2K2MIXKXWDkLYdwPKl.zPn+sl1uJVjA
S8RO2qTXYbpZG8gfnTR3M5kY7u7cVrbXNctXnyGgQw23pmMlpQcQ+cyVhzb9
tp4uLc4SflRfZy3RVxoSz4KmWrgxtnwHS4glyHa8nzgKL1PciMu2CXC2M1be
OfMmtwly6Ar41M1vuGvlW2XC8d.aq6Fav2CXyuarYuHXSsZ21Qs5FaXiLrbf
.MJBBeAUFyByRUKnuLfuJ4iawlyM6QG6b5tkB6vQpbcVTFzdjnnBtKBJbQiE
ENKMJFiIs6RhBG7H4BzRBhqQe.WHPfGo5nCa3V91AH8htWqWYYv5S2rf.+Jz
fCDSBV.UbPMbquYgvsIJ4Xn7pLSKHLFeduAovpH4A35w0CvKHIN5fY1iD7He
uZFtE2rTXejH2s+XOkMV88xKqVDyG.dfRE4p9Pk88ouODktkD05qN1022b1K
FiVmkxyDNSWrJSqLmJ+BAPj27WzVSpNJ6qfQQq.E0of.HORA63DwQfo9t9m4
opQMUsF1TsAAdWeUidGKQMGMVcvKUIpAm8RNru5GcOS4lRRD6S4wCaJidK5.
CMKm1T8KyW8jZM2tt4wjr+B9rBTgLkodQECIT6r3yEmwVBmHo.6UpaYJVWGL
T.ft1fOq3hPlPp5zU+vIT1giaUgUE.2oY.gMIpbMGh5r56CmlyeQP6b10JMl
uDE1srlxrmU8Ob3x0rruBfWUldmUL0o.86t4o9YXj1INK4kgWmbeKRw8bxxK
n9wNQX6QLSH3bLSiQjlkYB4OhopIC27.WV1YtnFu6Zpsuso1cL7avbPu3wNS
vaclfigN8mAYphXVd2.n6cyO.NJ9Ct9hoxD9pUMxVLKspM1V0E6k0Da+0Ca6
ZgUut99pA1G+yi+2N4Wiu
-----------end_max5_patcher-----------
</code></pre>

[rconstanzo]

Haven't tested all the permutations of this, but the <6d thing also instacrashes pd (0.53):

[tremblap]

actually this is a duplicate of #278 and there is now a fix.

[tremblap]

fix proposed at #279