You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
actually, some of them are rectified, in algo/util/OnsetDetectionFuncs.hpp
so we should eyeball it. If half-wave rectifying looks like it ends up losing meaningful peaks, then we should abs and vice-versa: if abs introduces what seems to be spurious peaks (harder to interpret in some cases), then half-wave it is
What was the expected result?
yes
What was the actual result?
no
What operating system were you using?
Mac
Operating system version
mac
FluCoMa Version
1.0.7
The text was updated successfully, but these errors were encountered:
tremblap
changed the title
Bug: max(0) or abs() the novelty curve post detrending
Bug: max(0) or abs() the onset feature curve post detrending
Dec 12, 2024
Please tell us what you were doing! You can include code and files by drag and dropping them into the text area.
this line in the onset detection funcs code should be taking the abs of the value before returning
flucoma-core/include/algorithms/public/OnsetDetectionFunctions.hpp
Line 113 in 00061f4
actually, some of them are rectified, in algo/util/OnsetDetectionFuncs.hpp
so we should eyeball it. If half-wave rectifying looks like it ends up losing meaningful peaks, then we should abs and vice-versa: if abs introduces what seems to be spurious peaks (harder to interpret in some cases), then half-wave it is
What was the expected result?
yes
What was the actual result?
no
What operating system were you using?
Mac
Operating system version
mac
FluCoMa Version
1.0.7
The text was updated successfully, but these errors were encountered: