Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: max(0) or abs() the onset feature curve post detrending #287

Open
tremblap opened this issue Dec 12, 2024 · 0 comments
Open

Bug: max(0) or abs() the onset feature curve post detrending #287

tremblap opened this issue Dec 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tremblap
Copy link
Member

Please tell us what you were doing! You can include code and files by drag and dropping them into the text area.

this line in the onset detection funcs code should be taking the abs of the value before returning

actually, some of them are rectified, in algo/util/OnsetDetectionFuncs.hpp

so we should eyeball it. If half-wave rectifying looks like it ends up losing meaningful peaks, then we should abs and vice-versa: if abs introduces what seems to be spurious peaks (harder to interpret in some cases), then half-wave it is

What was the expected result?

yes

What was the actual result?

no

What operating system were you using?

Mac

Operating system version

mac

FluCoMa Version

1.0.7

@tremblap tremblap added the bug Something isn't working label Dec 12, 2024
@tremblap tremblap changed the title Bug: max(0) or abs() the novelty curve post detrending Bug: max(0) or abs() the onset feature curve post detrending Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant