Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake install routine messes-up the helpfiles #107

Closed
tremblap opened this issue May 31, 2022 · 9 comments
Closed

cmake install routine messes-up the helpfiles #107

tremblap opened this issue May 31, 2022 · 9 comments
Assignees

Comments

@tremblap
Copy link
Member

This picture shows, that post install, the folder created has both the old (wrong) helpfiles in the right folder (Classes) and an extra folder (sc_ref) with the right helpfiles in them...

Screenshot 2022-05-31 at 13 53 26

I did all my pr reviews on the wrong ones because of this :( I'm sad.

@weefuzzy
Copy link
Member

There will be a missing slash in the install command (or vice versa, never remember). Although this also raises a question for @tedmoore about when we're going to zap old help files.

@weefuzzy
Copy link
Member

Missing slash, I think. Try the change to l264 of CMakeLists.txt

  install(DIRECTORY "${SC_DOC_OUT}/" 
          DESTINATION "${SC_PACKAGE_ROOT}/HelpSource")

@jamesb93
Copy link
Member

Line 264

@jamesb93
Copy link
Member

Oops you beat me.

@tremblap
Copy link
Member Author

I'll let @tedmoore decide when/how best to move.

@tremblap
Copy link
Member Author

in the meantime since it messes up the CI too I'll push the line change after testing it if @weefuzzy agrees

@tedmoore
Copy link
Member

What would be lost by zapping the old help files? What is being zapped? Aren't we already building all the SC help from flucoma-docs?

@tremblap
Copy link
Member Author

it is about the structure of what goes where. as in ticket #72 so I'll close this one and we can talk of what we put where later. in this case IIUC we will overwrite if a file is in both sc_ref and in the old fixed copy...

@tremblap
Copy link
Member Author

this is sorted but now shows a new problem. new ticket on its way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants