Issue in JSON generation scripts (some test suites are badly generated) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsanchez87
requested review from
mdimopoulos
and removed request for
mdimopoulos
mdimopoulos
changed the title
mdimopoulos
changed the title
rsanchez87
changed the title
gen_jvt.py Added exceptions for test vectors that produce key errors when analyzed with ffprobe gen_jct_vc.py tiny naming improvement gen_jvet.py Added exceptions for test vectors that cause ffprobe errors, preparing the script for future use with ffprobe mode enabled - Replaced 2 test suites - Made tweaks for special test vectors in utils.py and codec.py
|
Finally, we needed to separate some test vectors, great job @mdimopoulos , now all diffs between JSON generated and stored in (resources) are empty. You can approve the PR to merge |
rsanchez87
requested review from
mdimopoulos
and removed request for
mdimopoulos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.