Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LIST and CHANNEL data types #32

Open
iridian-ks opened this issue Jun 18, 2021 · 1 comment
Open

Add support for LIST and CHANNEL data types #32

iridian-ks opened this issue Jun 18, 2021 · 1 comment

Comments

@iridian-ks
Copy link

Problem

We have existing log stacks that use LIST or CHANNEL data types and does not support HASH_MAP.

Steps to replicate

Use a log consumer that only supports LIST or CHANNEL data types.

Expected Behavior

The fluent-plugin-redis configuration allows to specify which data type to use. Currently, only HASH MAP is supported.

Suggested changes

  1. Add a new config option in the plugin called data_type. Default this to HASH_MAP. Allow for options HASH_MAP, LIST, CHANNEL.
  2. HASH_MAP type works as it does today with no changes
  3. LIST option will use RPUSH
  4. CHANNEL option will use PUBLISH
  5. Document that allow_duplicate_key and possibly ttl is only valid for HASH_MAP
  6. Document that key_prefix can be used to select a different LIST or CHANNEL

I am prepared to make the updates to the plugin but want a confirmation that such changes will be accepted in a PR.

Thank you!! :)

@fujimotos
Copy link

@iridian-ks FWIW, I implemented Pub/Sub support in #33. Please comment
to that pull request, if you have any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants