Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Added Daemonset yaml for Kubernetes cluster v1.16+ and updated README. #71

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AATHITH
Copy link

@AATHITH AATHITH commented Apr 6, 2020

  1. Added a fluent-bit-Daemonset YAML file(new API version and selectors) which works in kubernetes cluster v1.16 and above.
  2. Added kubectl create command for that in README.md file.
  3. Removed Duplicate to fix Readme is repetitive #67

@AATHITH AATHITH force-pushed the master branch 2 times, most recently from a12bee4 to 5fa4fa7 Compare April 6, 2020 10:06
@AATHITH AATHITH changed the title Added Daemonset yaml for Kubernetes cluster v1.16 and above Added Daemonset yaml for Kubernetes cluster v1.16+ and updated README. Apr 6, 2020
version: v1
kubernetes.io/cluster-service: "true"
spec:
selectors:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this line gave me an error. I had to change it to the singular form 'selector'.

[ValidationError(DaemonSet.spec): unknown field "selectors" in io.k8s.api.apps.v1.
DaemonSetSpec, ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec]

Copy link
Author

@AATHITH AATHITH May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing out. Fixed.

@edsiper
Copy link
Member

edsiper commented May 19, 2020

I think we should not add a new file, just make all adjustments assuming everybody is on > 1.16

This YAML is compatible with kubernetes version 1.16 and above.

Signed-off-by: AATHITH <[email protected]>
added kubectl create daemonset command for Kubernetes cluster v1.16 and above

Signed-off-by: AATHITH <[email protected]>

modified:   README.md
Signed-off-by: AATHITH <[email protected]>
@solsson
Copy link
Contributor

solsson commented Aug 10, 2021

I think #66 and #84 together replace the two parts of this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme is repetitive
4 participants