Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_forward: the max size of gzipped message should be optional #9286

Closed
ksauzz opened this issue Aug 27, 2024 · 3 comments
Closed

in_forward: the max size of gzipped message should be optional #9286

ksauzz opened this issue Aug 27, 2024 · 3 comments
Labels

Comments

@ksauzz
Copy link
Contributor

ksauzz commented Aug 27, 2024

Is your feature request related to a problem? Please describe.

I observed the following error message because of hitting the max size of gzipped message, and the logs seems dropped as a result.

[2024/08/27 01:07:36] [error] [input:forward:forward.0] gzip uncompress failure
[2024/08/27 01:07:36] [error] [gzip] maximum decompression size is 100MB

Describe the solution you'd like

  • option1: Remove the check of the max limit of decompression size.
  • option2: Add a config item to disable to check the max limit of decompression size.
  • option3: Config item to change the max limit of decompression size

It would be nice to change this check just warning instead of error.

Describe alternatives you've considered

I think typical users don't need this kind of max limit, because modern deployments like k8s has auto recovery features from OOM. Dropping logs is more critical issue for users than OOM.

Additional context

I observed the errors after upgrading fluent-bit from 2.1.10 to 3.1.6, but the validation itself was introduced in 1.8.0.

@ksauzz ksauzz changed the title out_forward: the max size of gzipped message should be optional in_forward: the max size of gzipped message should be optional Aug 27, 2024
@ksauzz
Copy link
Contributor Author

ksauzz commented Aug 27, 2024

Related to #9058

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

@github-actions github-actions bot added the Stale label Dec 15, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant