Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Slow service start (fluent-package) #618

Closed
daipom opened this issue Feb 16, 2024 · 2 comments
Closed

Windows: Slow service start (fluent-package) #618

daipom opened this issue Feb 16, 2024 · 2 comments
Assignees
@daipom
Labels
Windows
Milestone
5.0.3

Comments

@daipom
Copy link
Contributor

daipom commented Feb 16, 2024

Abst

Details

Windows service startup is noticeably slower for fluent-package.
I'm talking about the time to reach the Running state. In other words, the time to finish StartServiceCtrlDispatcher.
For td-agent, it takes about 5 seconds, but for fluent-package it can take more than 20 seconds.

Windows service needs to finish StartServiceCtrlDispatcher in 30 seconds by default.
So, this problem can cause timeout errors.

EventID 7000

The testservice service failed to start due to the following error: 
The service did not respond to the start or control request in a timely fashion.

EventID 7009

A timeout was reached (30000 milliseconds) while waiting for the testservice service to connect.

Reproduce

If you try to start the service several times, it will often take 10 to 20 seconds.

I confirm this problem in the following:

  • Windows 10 Home 64bit
    • 4 core CPU, 8 logical processors (Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz 1.99GHz)
    • 16GB RAM
  • AWS EC2 instance Windows Server 2019 Base
    • t2.medium
    • t2.large
    • c5.large

Interestingly, this problem does not occur in t2.small EC2 instance type.
I think it occurs in environments with multiple CPUs.
@daipom daipom added the Windows label Feb 16, 2024
@daipom daipom added this to the 5.0.3 milestone Feb 16, 2024
@daipom daipom self-assigned this Feb 16, 2024
@ashie ashie mentioned this issue Feb 28, 2024
Closed
@daipom
Copy link
Contributor Author

daipom commented Feb 28, 2024

chef/win32-service#85 will fix this issue.

@ashie ashie mentioned this issue Mar 7, 2024
Closed
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
@kenhys
msi: fix slow start issue on Windows
16a7871 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
@kenhys
msi: fix slow start issue on Windows
28c4287 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys mentioned this issue Mar 7, 2024
Merged
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
@kenhys
msi: fix slow start issue on Windows
c2059bf 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
@kenhys
msi: fix slow start issue on Windows
c71f898 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
@kenhys
msi: fix slow start issue on Windows
49263d4 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 7, 2024
@kenhys
msi: fix slow start issue on Windows
c95b121 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 11, 2024
@kenhys
msi: fix slow start issue on Windows
fa99bc3 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service", branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 12, 2024
@kenhys
msi: fix slow start issue on Windows
dabb717 
Until chef/win32-service#85 is merged,

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 12, 2024
@kenhys
msi: fix slow start issue on Windows
e7d822d 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
@kenhys
msi: fix slow start issue on Windows
61b55d5 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
@kenhys
msi: fix slow start issue on Windows
c5d14fe 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
@kenhys
msi: fix slow start issue on Windows
af38a0c 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
@kenhys
msi: fix slow start issue on Windows
14d465b 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
@kenhys
msi: fix slow start issue on Windows
7e873b8 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit to kenhys/fluent-package-builder that referenced this issue Mar 13, 2024
@kenhys
msi: fix slow start issue on Windows
ca4bea6 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See fluent#618

Closes: fluent#630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]

Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys added a commit that referenced this issue Mar 13, 2024
@kenhys
msi: fix slow start issue on Windows (#631)
44dfadd 
Until chef/win32-service#85 is merged,
use forked version of win32-service.

This fix should be applied to fluent-package not to block starting
fluentdwinsvc service on Windows.

See #618

Closes: #630

NOTE: even though just putting the following line
does not install forked version of win32-service, so
install it explicitly as same as fluentd gem.

```
  gem "win32-service", github: "fluent-plugins-nursery/win32-service",
  branch: "fluent-package", platforms: [:mingw, :x64_mingw]
```

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor

kenhys commented Mar 14, 2024

it should be fixed via #630

@kenhys kenhys closed this as completed Mar 14, 2024
@daipom daipom mentioned this issue Mar 25, 2024
Merged
daipom added a commit that referenced this issue Mar 27, 2024
@daipom @kenhys
CI: Check time to start service on Windows (#637)
9d71876 
Add a test for #618
On v5.0.2, I have confirmed it takes 4.6s ~ 6.7s.
Since v5.0.3, it takes less than 1s.

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
@daipom daipom mentioned this issue Apr 8, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daipom daipom

Labels
Windows
Projects
None yet
Milestone
5.0.3
Development

No branches or pull requests
2 participants
@kenhys @daipom