Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove titleCorrespondence #115

Open
benhuangbmj opened this issue Dec 9, 2024 · 2 comments
Open

Remove titleCorrespondence #115

benhuangbmj opened this issue Dec 9, 2024 · 2 comments

Comments

@benhuangbmj
Copy link
Member

benhuangbmj commented Dec 9, 2024

Update: We decided to remove this.


https://github.com/flushingtech/Votte_Backend/blob/ed98ba651876e3c7fbbb96725878dded192a1a19/src/routes/eventsRoutes.js#L24-L28
https://github.com/flushingtech/Votte_Backend/blob/ed98ba651876e3c7fbbb96725878dded192a1a19/src/routes/eventsRoutes.js#L45-L46

The keys and values in titleCorrespondence should be flipped, otherwise, the eventTitle would always just be the one from the RSS feed.

Discussion: Do we really want to convert the event title?
Context: The only reason we use this conversion is because the titles of the same event on flushingtech.org and meetup.com/flushing-tech/events are different.
Consequence: The decision of this issue will affect the implementation of flushingtech/Votte_Backend#29 and flushingtech/Votte_Backend#30 .

@benhuangbmj benhuangbmj added the bug Something isn't working label Dec 9, 2024
@wilrnh
Copy link
Contributor

wilrnh commented Dec 11, 2024

ah good catch. i'd say just use the one from meetup 👍

(i think this was just a carryover from the old site)

@benhuangbmj
Copy link
Member Author

ah good catch. i'd say just use the one from meetup 👍

(i think this was just a carryover from the old site)

Got you.

@benhuangbmj benhuangbmj changed the title The key-value in titleCorrespondence flipped Remove titleCorrespondence Dec 12, 2024
@benhuangbmj benhuangbmj removed the bug Something isn't working label Dec 12, 2024
@wilrnh wilrnh transferred this issue from flushingtech/Votte_Backend Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants