From 4a1e9d1400fdb9060be9e9aa4108ef84753a2f53 Mon Sep 17 00:00:00 2001 From: Kenzie Schmoll Date: Wed, 1 Nov 2023 12:48:59 -0700 Subject: [PATCH] Add a TODO to investigate chmod --- tool/lib/commands/build_release.dart | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/tool/lib/commands/build_release.dart b/tool/lib/commands/build_release.dart index 78282d8dd01..a6fc0d041b0 100644 --- a/tool/lib/commands/build_release.dart +++ b/tool/lib/commands/build_release.dart @@ -72,12 +72,17 @@ class BuildReleaseCommand extends Command { workingDirectory: repo.devtoolsAppDirectoryPath, ); - final canvaskitDir = Directory( - path.join(repo.devtoolsAppDirectoryPath, 'build', 'web', 'canvaskit'), - ); - for (final file in canvaskitDir.listSync()) { - if (RegExp(r'canvaskit\..*').hasMatch(file.path)) { - await processManager.runProcess(CliCommand('chmod 0755 ${file.path}')); + // TODO(kenz): investigate if we need to perform a windows equivalent of + // `chmod` or if we even need to perform `chmod` for linux / mac anymore. + if (!Platform.isWindows) { + final canvaskitDir = Directory( + path.join(repo.devtoolsAppDirectoryPath, 'build', 'web', 'canvaskit'), + ); + for (final file in canvaskitDir.listSync()) { + if (RegExp(r'canvaskit\..*').hasMatch(file.path)) { + await processManager + .runProcess(CliCommand('chmod 0755 ${file.path}')); + } } } }