Add support for "Open DevTools in Browser" in Sidebar menu #6736
Conversation
packages/devtools_app/lib/src/standalone_ui/vs_code/debug_sessions.dart
Outdated
Show resolved
Hide resolved
| disabledReason = 'Not available when running on the web'; | ||
| } | ||
|
|
||
| Widget devToolsButton( |
There was a problem hiding this comment.
instead of using a helper method, can you create a helper widget like in my draft PR here: https://github.com/flutter/devtools/pull/6709/files#diff-e976c2386d5c7dc8f65bcad658ee5fba12faf0c519c2ad34664c78465fd9129fR275-R306
There was a problem hiding this comment.
Done! (unfortunately you're going to have some conflicts here)
|
I made the requested changes - if there's any feedback on those changes, I'll address in another PR (I figure it's good to land this before our two conflicting PRs diverge further). |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/devtools/6736, due to - The status or check suite Dart Code Metrics has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/devtools/6736, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Failure is #6492, re-running... |
This adds a new entry to the DevTools menu in the sidebar to "Open in Browser" (matching the extra option for this when you run the "Open DevTools" command from the VS Code command palette):
This will open whatever the default page is in DevTools for this type of app, and will always open in a browser window regardless of the user-settings for embedded/external.
See #6563