Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin package:web 0.4.0 #6750

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Pin package:web 0.4.0 #6750

merged 2 commits into from
Nov 20, 2023

Conversation

srujzs
Copy link
Contributor

@srujzs srujzs commented Nov 16, 2023

Now that Flutter main has moved to ^0.4.0, we can pin this version.

@srujzs srujzs requested review from kenzieschmoll and a team as code owners November 16, 2023 17:04
@srujzs
Copy link
Contributor Author

srujzs commented Nov 16, 2023

Hmm, maybe we need to update the Flutter version constraint in the pubspecs?

@kevmoo
Copy link
Contributor

kevmoo commented Nov 16, 2023

Do you want to follow-up with #6753 ?

@kevmoo
Copy link
Contributor

kevmoo commented Nov 16, 2023

Hmm, maybe we need to update the Flutter version constraint in the pubspecs?

That shouldn't matter. The version of Flutter that's tested here just needs to roll forward to the version where you updated the pin dep

@srujzs
Copy link
Contributor Author

srujzs commented Nov 16, 2023

Ah yes, we should remove the last imports of dart:html in this PR too. I'll incorporate your changes into here.

The version of Flutter that's tested here just needs to roll forward to the version where you updated the pin dep.

I thought the Flutter environment constraint was the version of Flutter that's being tested. Is that defined elsewhere?

Now that Flutter main has moved to ^0.4.0, we can pin this
version.
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srujzs srujzs merged commit 0c5c5f6 into flutter:master Nov 20, 2023
22 of 23 checks passed
@kevmoo kevmoo mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants