Always use tool/flutter-sdk for devtools_tool + remote FLUTTER_ROOT #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some code I added to support using FLUTTER_ROOT for the SDK and instead just updates the devtools_tool shell scripts to always run from tools/flutter-sdk and just locate the Flutter SDK from the running VM. This makes the assumption that we _always_ want to use the DevTools version of Flutter and avoids any issues where you might have something different on PATH. It also renames the --use-flutter-from-path flag to --update-flutter/--no-update-flutter (and retains the default of updating).
DanTup
changed the title
tool/lib/commands/shared.dart
Outdated
| BuildCommandArgs.updateFlutter.flagName, | ||
| negatable: true, | ||
| defaultsTo: true, | ||
| help: 'Whether to update the Flutter SDK before building DevTools ' |
There was a problem hiding this comment.
nit: remove "before building DevTools" because this flag can be used for more than just the build command.
After removing, it should say 'Whether to update the Flutter SDK contained in the "tool/flutter-sdk" directory'
There was a problem hiding this comment.
Done!
- another minor fix I forgot to push earlier, which ensures if you pass
--no-update-flutterwe remove it before passing on to the local server.
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/devtools/6776, due to - The status or check suite benchmarks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/devtools/6776, due to - The status or check suite benchmarks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Reverted this temporarily to unblock Flutter. |
DanTup
added a commit
to DanTup/devtools
that referenced
this pull request
Nov 23, 2023
…e FLUTTER_ROOT (flutter#6776)" (flutter#6820)" This reverts commit 79cde66.
DanTup
added a commit
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some code I added to support using
FLUTTER_ROOTfor the SDK and instead just updates thedevtools_toolshell scripts to always run fromtools/flutter-sdkand just locate the Flutter SDK from the running VM.This makes the assumption that we always want to use the DevTools version of Flutter and avoids any issues where you might have something different on
PATH.It also renames the
--use-flutter-from-pathflag to--update-flutter/--no-update-flutter(and retains the default of updating).