Skip to content

Conversation

@lauweijie
Copy link

@lauweijie lauweijie commented Nov 10, 2025

It looks like the chromium team is considering disabling the default video poster feature: https://issues.chromium.org/issues/40755557. This changes it to an empty bitmap for now.

Fixes flutter/flutter#178263.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the legacy Android video poster image by overriding WebChromeClient.getDefaultVideoPoster to return a minimal transparent bitmap. This prevents the default gray play icon from showing on videos before they start. The change is accompanied by a new unit test and a changelog update. My review focuses on the correctness of the implementation and the quality of the test. I have one suggestion to make the new test more specific and robust.

@stuartmorgan-g stuartmorgan-g added the triage-android Should be looked at in Android triage label Nov 11, 2025
@reidbaker reidbaker requested a review from gmackall November 11, 2025 18:10
@bparrishMines
Copy link
Contributor

Opted out to land in downstream fork for now.

@fluttergithubbot
Copy link

An existing Git SHA, ab5b85c8b01177f3673950a056c7f188b116b505, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@bparrishMines bparrishMines marked this pull request as draft November 11, 2025 20:47
@reidbaker
Copy link
Contributor

@lauweijie is this ready for review or did you want it to be a draft?

@bparrishMines
Copy link
Contributor

@reidbaker I set this as a draft while we wait to see what the process will be to roll this plugin internally. It's only open still to ensure that we revisit it after a decision. But I'm also open to closing it for now if it is easier for triage teams.

@reidbaker
Copy link
Contributor

I just wanted to make sure that it wasn't accidentally marked as draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: webview_flutter platform-android triage-android Should be looked at in Android triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable legacy Android video poster on webview

5 participants