-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[webview_flutter] Disable legacy Android video poster #10395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request disables the legacy Android video poster image by overriding WebChromeClient.getDefaultVideoPoster to return a minimal transparent bitmap. This prevents the default gray play icon from showing on videos before they start. The change is accompanied by a new unit test and a changelog update. My review focuses on the correctness of the implementation and the quality of the test. I have one suggestion to make the new test more specific and robust.
...ter_android/android/src/test/java/io/flutter/plugins/webviewflutter/WebChromeClientTest.java
Show resolved
Hide resolved
|
Opted out to land in downstream fork for now. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
@lauweijie is this ready for review or did you want it to be a draft? |
|
@reidbaker I set this as a draft while we wait to see what the process will be to roll this plugin internally. It's only open still to ensure that we revisit it after a decision. But I'm also open to closing it for now if it is easier for triage teams. |
|
I just wanted to make sure that it wasn't accidentally marked as draft. |
It looks like the chromium team is considering disabling the default video poster feature: https://issues.chromium.org/issues/40755557. This changes it to an empty bitmap for now.
Fixes flutter/flutter#178263.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3