-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[image_picker] redesign example app #9625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
JFYI you need to update the change log. There is a failing test complaining about that. |
The iOS example now uses FloatingActionButton.extended
@rekire Thank you for looking into the failing test. I've updated the changelog but was not sure wether a version bump is necessary. Could you please confirm? |
test-exempt: this is a Flutter-team-facing test app, so doesn't need testing of UI |
CHANGELOG/version override: Although this file is published to pub.dev, the change here isn't relevant to package clients, only to local package developers, so it doesn't matter if/when it is published. |
Replaces FloatingActionButton with FloatingActionButton.extended in Linux, macOS, and Windows example apps for improved button labeling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@4a231ae...cb8fef6 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.9.3 to 1.10.1 in /packages/image_picker/image_picker_android/android (flutter/packages#8725) 2025-07-17 [email protected] [webview_flutter] Update androidx.webkit to 1.14.0 (flutter/packages#9638) 2025-07-17 [email protected] Roll Flutter from c2739f0 to 9c626d9 (18 revisions) (flutter/packages#9641) 2025-07-17 [email protected] Roll Flutter (stable) from 077b4a4 to d7b523b (3 revisions) (flutter/packages#9640) 2025-07-17 [email protected] Fix Gemini note wrapping (flutter/packages#9639) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.android.gms:play-services-maps from 18.2.0 to 19.2.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#9120) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.fragment:fragment from 1.6.2 to 1.8.8 in /packages/local_auth/local_auth_android/android (flutter/packages#9406) 2025-07-16 [email protected] [ci] Add Gemini Code Assist review config (flutter/packages#9632) 2025-07-16 [email protected] Roll Flutter from cc3110c to c2739f0 (15 revisions) (flutter/packages#9633) 2025-07-16 [email protected] [image_picker] redesign example app (flutter/packages#9625) 2025-07-16 [email protected] [camera_avfoundation] Implementation swift migration - part 7 (flutter/packages#9595) 2025-07-15 [email protected] [webview_flutter_wkwebview] Replace Flutter method failure assertion with nslog (flutter/packages#9587) 2025-07-15 [email protected] Roll Flutter from a930ec1 to cc3110c (24 revisions) (flutter/packages#9631) 2025-07-15 [email protected] [webview_flutter] Add setMixedContentMode for Android (flutter/packages#9586) 2025-07-15 [email protected] [google_sign_in] Add exception info to migration guide (flutter/packages#9574) 2025-07-14 [email protected] [camera_android] Use WeakReference to prevent startImageStream OOM error when main thread hangs (#166533) (flutter/packages#9571) 2025-07-14 [email protected] [quick_actions] Restore the appShortcutLaunchActivityAfterStarting test in quick_actions_android (flutter/packages#9508) 2025-07-14 [email protected] Roll Flutter from 35f197f to a930ec1 (3 revisions) (flutter/packages#9624) 2025-07-14 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.1 to 8.11.1 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#9618) 2025-07-12 [email protected] Roll Flutter from 43657f3 to 35f197f (39 revisions) (flutter/packages#9602) 2025-07-11 [email protected] Replace popularity badges (flutter/packages#9594) 2025-07-11 [email protected] [rfw] Update test to not depend on toString() (flutter/packages#9590) 2025-07-11 [email protected] [camera_avfoundation] Implementation swift migration - part 6 (flutter/packages#9588) 2025-07-10 [email protected] [url_launcher] Fixes new unnecessary boolean operations warnings (flutter/packages#9409) 2025-07-10 [email protected] [google_sign_in] Add troubleshooting to Android README (flutter/packages#9581) 2025-07-10 [email protected] Roll Flutter from ac12f66 to 43657f3 (25 revisions) (flutter/packages#9589) 2025-07-10 [email protected] [go_router_builder] Update case sensitive test to `go_router` 16.0.0 (flutter/packages#9482) 2025-07-09 [email protected] [rfw] Remove the RFW WASM example (flutter/packages#9551) 2025-07-09 [email protected] Roll Flutter (stable) from fcf2c11 to 077b4a4 (5 revisions) (flutter/packages#9585) 2025-07-09 [email protected] Roll Flutter from adffe24 to ac12f66 (28 revisions) (flutter/packages#9584) 2025-07-09 [email protected] [video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions (flutter/packages#8940) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Replace default
FloatingActionButton
s withFloatingActionButton.extended
to add text labels describing each button's actionfixes flutter/flutter#165888
|
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3