Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds wide gamut framework breakage notice. #11082

Merged
merged 12 commits into from
Sep 6, 2024

Conversation

gaaclarke
Copy link
Member

Description of what this PR is changing or adding, and why:

Adding breaking change notice for wide gamut colors in the framework.

Issues fixed by this PR (if any):

flutter/flutter#127855

PRs or commits this PR depends on (if any):

flutter/engine#54737

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@gaaclarke gaaclarke requested a review from matanlurey August 26, 2024 21:26
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. Thanks for writing this up!

src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gaaclarke, for such a thorough review. Let's iterate. :D

src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
src/release/breaking-changes/wide-gamut-framework.md Outdated Show resolved Hide resolved
@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Aug 29, 2024
gaaclarke and others added 2 commits August 29, 2024 14:03
shams 1

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 3, 2024

/gcbrun

@gaaclarke
Copy link
Member Author

Note: added a section specifically for "opacity" in response to feedback from flutter/flutter#154491

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 3, 2024

@parlough, two questions:

  1. Staging is failing with "File cloud_build/stage.yaml not found". What is that about?
  2. I wanted to include the link of the generated page, showing that ":::note" is accurate, but I can't find the staged page. I guess because the cloud_build file is missing?

@gaaclarke gaaclarke marked this pull request as ready for review September 5, 2024 16:06
@gaaclarke gaaclarke requested review from parlough and a team as code owners September 5, 2024 16:06
@gaaclarke gaaclarke requested a review from RedBrogdon September 5, 2024 16:06
@sfshaza2 sfshaza2 removed the review.await-update Awaiting Updates after Edits label Sep 5, 2024
@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 5, 2024

/gcbrun

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 5, 2024

Visit the preview URL for this PR (updated for commit e02c419):

https://flutter-docs-prod--pr11082-wide-gamut-framework-2mwyak42.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaaclarke
Copy link
Member Author

Hey @sfshaza2, should https://flutter-docs-prod--pr11082-wide-gamut-framework-2mwyak42.web.app/release/breaking-changes show this as being added? I'm not sure where to preview the page or what to edit to make it show up there.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 5, 2024 via email

@gaaclarke
Copy link
Member Author

Yes, indeed! I meant to list that, but forgot.

Okay, I see where to edit that, but the link https://flutter-docs-prod--pr11082-wide-gamut-framework-2mwyak42.web.app/release/breaking-changes/wide-gamut-framework doesn't work. Is that the correct link for the preview of this page?

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 5, 2024

/gcbrun

@gaaclarke
Copy link
Member Author

@sfshaza2 I added the entry to the index.md if you want to double check that.

We no longer have to specify site.url.  :)
@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 6, 2024

The entry in the breaking change index page is good to go.
However, you've added the new breaking change page under "/src/release/..." This is no longer correct and why I couldn't find the file in the staged site. We now put our content under "/src/content/...".

@gaaclarke
Copy link
Member Author

The entry in the breaking change index page is good to go. However, you've added the new breaking change page under "/src/release/..." This is no longer correct and why I couldn't find the file in the staged site. We now put our content under "/src/content/...".

Moved, thanks.

@sfshaza2 sfshaza2 merged commit 2a2cdbe into flutter:main Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants