-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds wide gamut framework breakage notice. #11082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions. Thanks for writing this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gaaclarke, for such a thorough review. Let's iterate. :D
/gcbrun |
shams 1 Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
/gcbrun |
Co-authored-by: Loïc Sharma <[email protected]>
Note: added a section specifically for "opacity" in response to feedback from flutter/flutter#154491 |
@parlough, two questions:
|
/gcbrun |
Visit the preview URL for this PR (updated for commit e02c419): https://flutter-docs-prod--pr11082-wide-gamut-framework-2mwyak42.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey @sfshaza2, should https://flutter-docs-prod--pr11082-wide-gamut-framework-2mwyak42.web.app/release/breaking-changes show this as being added? I'm not sure where to preview the page or what to edit to make it show up there. |
Yes, indeed! I meant to list that, but forgot.
…On Thu, Sep 5, 2024 at 1:27 PM gaaclarke ***@***.***> wrote:
Hey @sfshaza2 <https://github.com/sfshaza2>, should
https://flutter-docs-prod--pr11082-wide-gamut-framework-2mwyak42.web.app/release/breaking-changes
show this as being added? I'm not sure where to preview the page or what to
edit to make it show up there.
—
Reply to this email directly, view it on GitHub
<#11082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKS4PKLMSBUEVZ6DS3PNJR3ZVC5DRAVCNFSM6AAAAABNEZ67SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSGU3TGMZTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Okay, I see where to edit that, but the link https://flutter-docs-prod--pr11082-wide-gamut-framework-2mwyak42.web.app/release/breaking-changes/wide-gamut-framework doesn't work. Is that the correct link for the preview of this page? |
/gcbrun |
@sfshaza2 I added the entry to the index.md if you want to double check that. |
We no longer have to specify site.url. :)
The entry in the breaking change index page is good to go. |
Moved, thanks. |
Description of what this PR is changing or adding, and why:
Adding breaking change notice for wide gamut colors in the framework.
Issues fixed by this PR (if any):
flutter/flutter#127855
PRs or commits this PR depends on (if any):
flutter/engine#54737
Presubmit checklist