-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Wasm documentation #11131
Update Wasm documentation #11131
Conversation
Documentation was last updated for Flutter 3.22 and was outdated and misleading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks great to me! @johnpryan, @kevmoo, Can you weigh in?
/gcbrun |
Whoops, sorry, just fixed a small mistake ( |
Visit the preview URL for this PR (updated for commit 5480f94): |
/gcbrun |
|
||
If the application doesn't load: | ||
```dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yjbanov @eyebrowsoffire – thoughts here?
holy amazing @JaffaKetchup ! thank you! |
(No worries, I do enjoy a good bit of documentation improvements :D) |
@yjbanov, @eyebrowsoffire, can one of you weigh in on @kevmoo's question? |
Gentle ping, @yjbanov @eyebrowsoffire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke to @yjbanov in person in NYC last week. This is good work, @JaffaKetchup. If we need more tweaks, we can do that in a follow up. Thx!
Description of what this PR is changing or adding, and why:
Documentation was last updated for Flutter 3.22 and was outdated and misleading. I've updated it to include that
flutter run
is now supported, removed the experimental mentions (which conflict with the fact that it's now stable). I've also slightly reorganised some parts, as they are less necessary now thatflutter run
works, and added a way to actually verify whether Wasm is being used (two different methods, because one does not always seem 100% reliable)Presubmit checklist