Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wasm documentation #11131

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Update Wasm documentation #11131

merged 2 commits into from
Sep 25, 2024

Conversation

JaffaKetchup
Copy link
Contributor

Description of what this PR is changing or adding, and why:

Documentation was last updated for Flutter 3.22 and was outdated and misleading. I've updated it to include that flutter run is now supported, removed the experimental mentions (which conflict with the fact that it's now stable). I've also slightly reorganised some parts, as they are less necessary now that flutter run works, and added a way to actually verify whether Wasm is being used (two different methods, because one does not always seem 100% reliable)

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

Documentation was last updated for Flutter 3.22 and was outdated and misleading
@JaffaKetchup JaffaKetchup requested review from sfshaza2, parlough and a team as code owners September 12, 2024 17:57
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks great to me! @johnpryan, @kevmoo, Can you weigh in?

@sfshaza2
Copy link
Contributor

/gcbrun

@JaffaKetchup
Copy link
Contributor Author

Whoops, sorry, just fixed a small mistake (flutter run web doesn't exist :D). The checks on the latest commit failed again.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 12, 2024

Visit the preview URL for this PR (updated for commit 5480f94):

https://flutter-docs-prod--pr11131-patch-1-n67mg8ux.web.app

@sfshaza2
Copy link
Contributor

/gcbrun


If the application doesn't load:
```dart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yjbanov @eyebrowsoffire – thoughts here?

@kevmoo
Copy link
Contributor

kevmoo commented Sep 12, 2024

holy amazing @JaffaKetchup ! thank you!

@JaffaKetchup
Copy link
Contributor Author

(No worries, I do enjoy a good bit of documentation improvements :D)

@sfshaza2
Copy link
Contributor

@yjbanov, @eyebrowsoffire, can one of you weigh in on @kevmoo's question?

@sfshaza2
Copy link
Contributor

Gentle ping, @yjbanov @eyebrowsoffire

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke to @yjbanov in person in NYC last week. This is good work, @JaffaKetchup. If we need more tweaks, we can do that in a follow up. Thx!

@sfshaza2 sfshaza2 merged commit a5e1478 into flutter:main Sep 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants