-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update url-strategies.md #11221
Update url-strategies.md #11221
Conversation
You can't add flutter_web_plugins directly using pub add. Its only included as part of the project if required by other dependencies like go_router.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It definitely makes sense to clarify that it doesn't need to be added from pub.
However, I believe relying on it as a transitive dependency isn't the only option. You can also specify it as a sdk dependency, similar to flutter_test
.
dependencies:
flutter:
sdk: flutter
flutter_web_plugins:
sdk: flutter
What do you think about suggesting this instead? Since the depend_on_referenced_packages
lint would report that it's not depended on if it it's retrieved through a transitive dependency.
Let me know what you think. Thanks again! :D
/gcbrun |
Visit the preview URL for this PR (updated for commit 62167ab): |
Updated based on feedback from parlough: flutter#11221 (review)
Thanks for the feedback, I've updated it based on your suggestions :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for those adjustments! Clarifying this will definitely be super helpful :)
/gcbrun |
You can't add flutter_web_plugins directly using pub add. Its only included as part of the project if required by other dependencies like go_router.
Description of what this PR is changing or adding, and why:
Added additional information on how to add flutter_web_plugins to project to use usePathUrlStrategy() function.
Issues fixed by this PR (if any):
You can't add flutter_web_plugins directly using pub add or other methods.
PRs or commits this PR depends on (if any):
Presubmit checklist