-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a "Flutter for Jetpack Compose developers" page #11232
base: main
Are you sure you want to change the base?
Conversation
added links from the legacy android page to compose version
Visit the preview URL for this PR (updated for commit 6d0f399): https://flutter-docs-prod--pr11232-for-compose-devs-vg3g9549.web.app |
I'm confused. How does this overlap with this: #11219 ? |
#11219 is a targeted flow for an add to app like thing for Flutter developers that need to add a Compose activity. This PR is speaking more to Compose developers who want to implement flutter and see how their knowledge transfers. There is minimal overlap. |
I actually cut down on the number of examples from the page I modeled it on, Flutter for SwiftUI devs (https://docs.flutter.dev/get-started/flutter-for/swiftui-devs). There are sections on animation and there concepts in that other page that didn't feel essential and were getting into the weeds. My goal here was targeting a developer who is conversant with Compose and wants to do Flutter. I think it's important to discuss the commonalities to allow them to hit the ground running with real apples to apples examples versus just a textual description. I can concede that maybe some things can be excerpted more aggressively and places where I listed the two common ways for "A" Compose concept that map to "B" Flutter implementation might be reduced to one. If you are proposing to cut out the Kotlin side of a section totally, it might be better to eliminate the section altogether. Eg The google fonts section could be excised totally with just a pointer to the recently updated typography page. |
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor changes, but lgtm
Thanks, @jwill! |
@jwill, I want to land this, but the code excerpts are out of date. Can you run |
(And also remove it from Draft state.) |
I hadn't removed it from draft state because I'm actively working on it and was reworking some things. Was planning to make those edits and post for review. |
Oh, @jwill! I misunderstood! |
Fixes to remove ios specific widgets and references
Description of what this PR is changing or adding, and why:
Adds a page for Flutter for Jetpack Compose devs.
Issues fixed by this PR (if any):
Fixes #5611 and #9051
PRs or commits this PR depends on (if any):
Presubmit checklist