Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue where the dark and tinted icons #597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vlazdra
Copy link

@vlazdra vlazdra commented Oct 8, 2024

Fixes: #596

I did notice that with my auto format turned on a bunch of other lines where modified as well. I've checked in the analysis_options.yaml file and the rule was turned on, so no idea why I'm the first to re-format the code.

Anyways, I've tested this in my project that has flavors, and it worked. The Dark and Tinted icons have been generated and added correctly so much so that when viewed via xCode 16 all icons are placed correctly in their corresponding place. Which was not the case prior to this change.

@vlazdra
Copy link
Author

vlazdra commented Oct 8, 2024

@MarkOSullivan94 Can you please take a look at this PR?

@MarkOSullivan94
Copy link
Collaborator

@MarkOSullivan94 Can you please take a look at this PR?

Thanks for opening the PR!

I've taken a look at the issue you opened and left you with a comment and once that's addressed I'll review the changes here

If you have auto formatted the code and it is not related to the issue, please remove it because it is out of scope and we can have that merged in another PR

@vlazdra
Copy link
Author

vlazdra commented Oct 9, 2024

Hey @MarkOSullivan94,

I've added more clarification on the issue.

Regarding the formatting topic, I’m using the existing formatter that's already integrated into the project to ensure my changes are properly formatted. However, this formatter applies changes to the entire file.

Is there a way to format only specific lines of code? If not, could we consider keeping the current formatting changes in this PR to avoid manually adjusting each line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Dark and Tinted icons are not placed in the correct directory
2 participants