Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image updates policy moves comments and alters indentation #1441

Closed
fragolinux opened this issue May 21, 2021 · 1 comment
Closed

image updates policy moves comments and alters indentation #1441

fragolinux opened this issue May 21, 2021 · 1 comment

Comments

@fragolinux
Copy link

Describe the bug

applying image update automation reformats yaml moving around comments (altering given order), and indents yaml sections back of 2 spaces

To Reproduce

Steps to reproduce the behaviour:

for comments:
original yaml block:

  values:
    # storage:
    #   multiWriteStorageClass: nfs

    ingress:
      host: lab
      extra:
        annotations:
          alb.ingress.kubernetes.io/tags: Env=LabQA
      annotations:
        certificate:
          arn: arn:aws:acm:eu-central-1:..........................

altered block:

  values:
    ingress:
      host: lab
      extra:
        annotations:
          alb.ingress.kubernetes.io/tags: Env=LabQA
      annotations:
        certificate:
          arn: arn:aws:acm:eu-central-1:..........................
    # storage:
    #   multiWriteStorageClass: nfs

for indentation:
original yaml block:

        database:
          connections:
            - name: readonlyRegular
              connectTimeoutMS: 60000
              socketTimeoutMS: 600000

altered block:

        database:
          connections:
          - name: readonlyRegular
            connectTimeoutMS: 60000
            socketTimeoutMS: 600000

Expected behavior

keep comments and indentation in the way it is in original files, altering just the image updates tagged lines...

@stefanprodan
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants