metadata is defined as object in CRDs and generated Json Schemas

[adusumillipraveen]

Describe the bug

• Currently flux CRDs define metadata as object.

metadata:
  type: object

• Same is the case with json schema artefacts in the Github Release.
• We use kubeconfom to validate the schema on flux config in CI.
• We have had cases where a couple of PRs with improper indentation on flux CRDs at metadata broke flux for a bit.
• Is it possible to provide full schema for metadata like https://github.com/yannh/kubernetes-json-schema/blob/master/master-standalone-strict/namespace.json#L21 ?

Steps to reproduce

1. Install flux with cli generated manifets
2. Add a ImagePolicy with broken metadata to flux config like:

apiVersion: image.toolkit.fluxcd.io/v1beta1
kind: ImagePolicy
metadata:
  name: demo-civil-citizen-ui
  annotations:
  hmcts.github.com/prod-automated: false

3. Validate the schema using kubeconform and it works
4. But kustomize controller will fail validation when applying the changes.

Expected behavior

• Json Schema and CRD to have full definition for metadata

Screenshots and recordings

No response

OS / Distro

N/A

Flux version

N/A

Flux check

N/A

Git provider

No response

Container Registry provider

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[stefanprodan]

We use Kubernetes controller-gen to generate the CRDs and schema from Go code. The metadata field comes from Kubernetes apimachinery, so I guess this needs to change upstream as we have no control over it. See https://github.com/fluxcd/kustomize-controller/blob/main/api/v1/kustomization_types.go#L300

[adusumillipraveen]

Looks like there is a relevant issue on it already, will add my comments there.